Adds support for custom alerthandlers #513
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashraffouda
requested review from
abom,
AhmedHanafy725,
m-motawea,
rkhamis,
waleedhammam and
xmonader
as code owners
abom
suggested changes
Nov 26, 2020
| @@ -155,6 +157,7 @@ def alert_raise( | |||
| data: dict = None, | |||
| timestamp: float = None, | |||
| traceback: dict = None, | |||
| send_alert: bool = True, | |||
There was a problem hiding this comment.
this used from the new handler, cause I raise alert in case the alert can not be sent
or should we log instead?
| """Register new alert handler | ||
|
|
||
| Arguments: | ||
| handler {callable} -- error handler callable |
There was a problem hiding this comment.
Should be:
Suggested change
| handler {callable} -- error handler callable | |
| handler (callable): error handler callable |
| handler {callable} -- error handler callable | ||
|
|
||
| Keyword Arguments: | ||
| level {int} -- exception level (default: {40}) |
There was a problem hiding this comment.
Should be:
Suggested change
| level {int} -- exception level (default: {40}) | |
| level (int): exception level (default: 40) |
| level {int} -- exception level (default: {40}) | ||
| """ | ||
| if (handler, level) not in self.handlers: | ||
| self.handlers.append((handler, level)) |
There was a problem hiding this comment.
No new line at the end of the file.
ashraffouda
force-pushed
the
development_alert_handler
branch
2 times, most recently
from
0757ade to
71534d7
Compare
Signed-off-by: Ashraf Fouda <[email protected]>
ashraffouda
force-pushed
the
development_alert_handler
branch
from
71534d7 to
d87b468
Compare
Codecov Report
@@ Coverage Diff @@
## development #513 +/- ##
===============================================
+ Coverage 68.56% 69.94% +1.38%
===============================================
Files 85 84 -1
Lines 3941 3820 -121
===============================================
- Hits 2702 2672 -30
+ Misses 1239 1148 -91
Continue to review full report at Codecov.
|
Signed-off-by: Ashraf Fouda <[email protected]>
abom
approved these changes
Nov 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ashraf Fouda [email protected]
Description
Adds support for custom alert handlers