-
Notifications
You must be signed in to change notification settings - Fork 5
refactor nettools and add tests #531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
120 commits
Select commit
Hold shift + click to select a range
d4f4b6e
fix: adding a forgotten default value for optional arg
sameh-farouk 1eb8913
feature: Adding compatibility to IPv6
sameh-farouk 95d36dd
docs: Update tcp_connection_test funcion docstring
sameh-farouk 186b18d
test: Adding tests for nettools.tcp_connection_test()
sameh-farouk 582312e
refactor: Simpelfying wait_connection_test() and removing redundant code
sameh-farouk ff77663
docs: Changes to wait_connection_test function docstring
sameh-farouk 6ae330c
test: Adding test for nettools.wait_connection_test()
sameh-farouk 47bfed5
fix: Respecting the timeout arg passed to nettools.wait_http_test()
sameh-farouk 5155f84
fix: nettools.check_url_reachable() gives false negative
sameh-farouk 0e36e82
feature: Add compatibility for IPv6 in get_reachable_ip_address()
sameh-farouk c053154
feature: Add compatibility to IPv6 in nettools.get_default_ip_config()
sameh-farouk 657e898
refactor: Refactor and optimize the code of get_network_info()
sameh-farouk d61e0f7
refactor: refactor and optimize nettools.ping_machine()
sameh-farouk 5fa45e8
fix: add apple specific option -o to exit after recv 1 replay packet
sameh-farouk 3234ef6
typo: update tests names to fix typo plublic -> public
sameh-farouk 5e1038c
refactor: update names of enclosing functions, following naming conve…
sameh-farouk 7166df1
refactor :Simplifying the return statement in check_url_reachable()
sameh-farouk 9ba8c77
refactor :Simplifying the return statement in ping_machine()
sameh-farouk 45b214e
docs: Declaring arguments and return type in functions annotations
sameh-farouk 1194847
refactor: remove unused imports
sameh-farouk ee49407
fix: Handling uncaught socket.timeout exception in check_url_reachable()
sameh-farouk 66a6de2
fix: Setting the default value of request headers to {} instead of None
sameh-farouk 0a1b904
test: Adding more tests for nettools
sameh-farouk 6c96cf0
test: Adding more tests for nettools and minor changes to some tests
sameh-farouk aba5785
feature: adding ipv6 compatibilty and minor tweaks in udp_connection_…
sameh-farouk 62d8b0e
fix: fixing TypeError in nettools.udp_connection_test()
sameh-farouk 2bcfeda
test: Adding test case for nettools.udp_connection_test()
sameh-farouk 98c22ac
Docs: Adding missing docstring to test_nettools.py and minor tweaks t…
sameh-farouk 7d9db1f
refactor: raising explicitly ValueError exception in case of invalid url
sameh-farouk 2912904
refactor: raising explicitly ValueError exception in case of invalid ip
sameh-farouk fcacc94
refactor: refacoring nettools.get_default_ip_config()
sameh-farouk b3dc114
test: Adding test case for nettools.get_nic_names()
sameh-farouk 7d748fb
test: Adding more tests
sameh-farouk 885d192
test: Adding more tests
sameh-farouk fa871a9
fix: trying to fix KeyError on CI test server
sameh-farouk e96b5df
test: adding debuging code to investigate KeyError on CI test server
sameh-farouk 0c8627f
test: adding debuging code to investigate KeyError on CI test server
sameh-farouk 78eaba3
fix: possible fix for get_network_info() KeyError on CI serevr
sameh-farouk 30fe84e
fix: possible fix for get_network_info() KeyError on CI serevr
sameh-farouk caa9096
refactor: Adding debug code and investigating CI issue
sameh-farouk 39c5797
fix: Replacing executors.run_local with subprocess.check_output
sameh-farouk ea61c3e
test: Adding test case for get_mac_address func
sameh-farouk db530cb
test: Adding no cover flag to proxy functions
sameh-farouk 8058fc7
fix: Correcting silly mistake var name output -> stdout
sameh-farouk 381cf15
Revert "fix: Replacing executors.run_local with subprocess.check_output"
sameh-farouk 2b9b349
investigate: Adding Debug code
sameh-farouk 180820a
fix: this should fix the unexpected output from get_network_info
sameh-farouk b9732d1
docs: Updating wait_http_test function docstring
sameh-farouk 69d3844
docs: Updating get_default_ip_config function docstring
sameh-farouk 2200d13
fix: reimplementing is_nic_connected for macOS
sameh-farouk cf28416
refactor: remove redundant code in is_nic_connected()
sameh-farouk 857b463
test: Adding tests for is_nic_connected()
sameh-farouk 08ef77d
Docs: Upadating ping_machine docstring
sameh-farouk 9ca1526
test: Adding tests for ping_machine function
sameh-farouk 93f1ce3
debug: Adding debug code toinvistigate build issue
sameh-farouk c9abb9c
feature: Allow ping_machine function to accept ipv6 address
sameh-farouk cdec418
test: Changes to ping_machine tests due to blocked inbound icmp packets
sameh-farouk ca42d82
refactor: Removing debug code
sameh-farouk a68d9dc
refactor: Optimize nettools.wait_connection_test function
sameh-farouk 2109399
refactor: use socket.listen method instead of nc command
sameh-farouk c598c3a
feature: Adding a new function get_free_port() to nettools
sameh-farouk a78a1ed
test: Refactoring the tests to use nettools.get_free_port()
sameh-farouk 3627955
mkae tcp_connection_test() raises exceptions in case of address-relat…
sameh-farouk 2380313
refactor: minor changes and refactoring
sameh-farouk e4a027c
refactor: remove unused import
sameh-farouk c964ac7
fix: replace executors.run_local with subprocess.check_output
sameh-farouk 4071ab1
reimplementing nettools.download function
sameh-farouk b68aa35
docs: changes to adheres to google style docstr
sameh-farouk 81393e6
docs: minor update to get_free_port docstr
sameh-farouk 891a6bd
tests: Adding new tests
sameh-farouk 2ecf550
tests: remove (missing_ok=False) arg from Path.unlink (py3.8 only fea…
sameh-farouk 086464c
test: mark test_28 as expected to fail
sameh-farouk 1a60e3e
test: fix test 23 fail on ubuntu 20.04
sameh-farouk 016b42a
Merge remote-tracking branch 'origin/development' into sameh-farouk-i…
sameh-farouk 9f5043c
docs: Apply suggestions from code review fixing typos in docstring
sameh-farouk fd2d752
Apply suggestions from code review - use _ for unused variable
sameh-farouk 3078ddc
refactor: remove redundant code
sameh-farouk ab019bc
refactor: simplifying an conditional expression
sameh-farouk f0d0f04
refactor: Rearranging the IDs of the tests
sameh-farouk 022e57a
docs: Formating the steps for the tests on the docstring
sameh-farouk 5266aa4
docs: update the steps for test Scenario #30 on the docstring
sameh-farouk bb0d475
docs: Generate tests docs
sameh-farouk 8b98030
docs: fix more typos in docstring
sameh-farouk a420fc5
format: Remove unnecessary comments floating around
sameh-farouk d50be09
test: Incorporating feedback - use sals.fs instead of os module
sameh-farouk 52258db
test: Incorporating feedback - use sals.fs instead of os module
sameh-farouk 680a2d7
Merge the remote branch
sameh-farouk 2eddf2d
feature: adding logging to nettools.tcp_connection_test func
sameh-farouk c8f550d
feature: updating logging for nettools.tcp_connection_test func
sameh-farouk 8713ec5
feature: adding logging to nettools.udp_connection_test func
sameh-farouk a64cce1
updating logging for nettools.tcp_connection_test func
sameh-farouk d8177ce
refactor: change the default waittime for wait_connection_test func
sameh-farouk a5ff3a4
feature: adding logging to nettools.wait_connection_test func
sameh-farouk 514cc34
fix: fixing an unnecessary sleep time in edge cases
sameh-farouk c2afd26
updating logging for nettools.wait_connection_test func
sameh-farouk b72ff39
feature: adding logging to nettools.wait_http_test func
sameh-farouk 603adf2
docs: Updating docstring for nettools.wait_connection_test func
sameh-farouk 1fcfb6e
feature: adding logging to nettools.check_url_reachable func
sameh-farouk 0f27855
refactor: Adding connection attempts counter to logging
sameh-farouk 71b3afc
fix: fixing ValueError object has no attribute message error
sameh-farouk efa288a
feature: adding logging to nettools.get_reachable_ip_address func
sameh-farouk f85926f
catching OverflowError raises if port number is invalid
sameh-farouk 6c20499
docs: update the module docstring
sameh-farouk 5e1922f
refactor: break out of the loop properly after finding the specified …
sameh-farouk 024ca51
docs: fix a typo
sameh-farouk ff0996c
feature: adding logging to nettools.get_network_info func
sameh-farouk facc897
feature: adding logging to nettools.is_nic_connected func
sameh-farouk fc74e3f
feature: adding logging to nettools.ping_machine func
sameh-farouk 604cf04
feature: adding logging to nettools.download func
sameh-farouk a0edfc9
docs: Upade nettools.get_free_port doctring
sameh-farouk 4903d92
feature: adding logging to nettools.get_free_port func
sameh-farouk ccc8c01
regenerate test docs
sameh-farouk 4dc6c1f
regenerate docs for nettools
sameh-farouk be84f4b
tests: replcae few print statments in unit tests with a proper logging
sameh-farouk 421c5f7
Merge branch 'development' into this feature branch
sameh-farouk a022711
Removing .tool-versions from repository
sameh-farouk 354d48f
updated module docstring with a brief
sameh-farouk 7f1fadd
refactor: Sorting imports
sameh-farouk bf1f450
refactor: Modifying the type of some logging messages
sameh-farouk 38fbde1
refactor: applying @abom code review
sameh-farouk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
refactor: Modifying the type of some logging messages
- Loading branch information
commit bf1f450adb0487c5e0818e154f0b0e83655353c9
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.