-
Notifications
You must be signed in to change notification settings - Fork 5
sals.process cleanup/refactor #555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
123 commits
Select commit
Hold shift + click to select a range
3cccf8a
refactor: remove unused import statements
sameh-farouk fe83c26
chore: Commenting the code
sameh-farouk e280c09
docs: Update excute() docstring
sameh-farouk 11a8152
refactor: Refactoring is_alive() & update its docstring
sameh-farouk 79841c4
refactor: Refactoring is_installed()
sameh-farouk a9b30a0
fix: Re-implementing kill() to fix a bug -> #557
sameh-farouk 516f411
refactor: Refactoring get_pids()
sameh-farouk 41c5670
refactor: Refactoring get_process_object
sameh-farouk 2869464
docs: Restyling the docstring to match google style
sameh-farouk a0d7e24
refactor: Refactoring check_running()
sameh-farouk 8eacd6f
docs: Updating check_running docsring
sameh-farouk b06b37c
refactor: Refactoring check_start()
sameh-farouk 99be231
refactor: Refactoring check_start()
sameh-farouk d9f73b9
refactor: Refactoring check_stop()
sameh-farouk de8f535
refactor: Refactoring ps_find()
sameh-farouk 67231a0
refactor: Refactoring kill_all()
sameh-farouk 76d9155
refactor: Refactoring kill_process_by_name()
sameh-farouk b59153c
refactor: Re-implementing get_defunct_processes()
sameh-farouk eb1ea86
refactor: Refactoring is_port_listening()
sameh-farouk 5b1a762
refactor: Refactoring get_user_processes()
sameh-farouk 815628e
refactor: Refactoring get_similar_processes()
sameh-farouk f89eede
refactor: Refactoring kill_user_processes()
sameh-farouk a0814b7
refactor: Refactoring check_process_for_pid()
sameh-farouk 4c2964e
refactor: Refactoring set_env_var()
sameh-farouk c9cc957
fix: Re-implementing get_process_by_port() issue #561
sameh-farouk 1fb04d0
refactor: Refactoring get_pid_by_port
sameh-farouk a4ae532
docs: Updating the docstring
sameh-farouk 43900f8
docs: Updating the docstring
sameh-farouk e0c7650
refactor: Refactoring kill_process_by_port
sameh-farouk 60ee42d
docs: Updating get_processes() docstring
sameh-farouk d556663
docs: Updating get_ports_mapping() docstring
sameh-farouk 49d7445
docs: Updating get_memory_usage() docstring
sameh-farouk b6f128f
refactor: Refactoring get_environ()
sameh-farouk a2cca8e
feature: Re-implementing get_processes_info() -> #467
sameh-farouk 42efde7
refactor: Refactoring get_pids_filtered_by_regex()
sameh-farouk 9b20ab1
refactor: Re-implementing get_pids_filtered_sorted() -> issue #467
sameh-farouk 20995cd
refactor: Re-implementing get_filtered_pids()
sameh-farouk 4cf0d42
docs: Updating the docstr
sameh-farouk ab961b9
refactor: sorting imports and remove the unused
sameh-farouk be9999f
docs: Updating the module docstring and outdated examples
sameh-farouk e610686
tests: Updating few tests to keep up with the sal changes
sameh-farouk 297c371
fix: Retunning True from kill() when the process no longer exists
sameh-farouk 36541b6
feature: Skipping errors when killing multiple Processes
sameh-farouk 858a9ff
feat: Adding logging to kill()
sameh-farouk 7ff1da4
docs: Upadting kill_all() and kill_process_by_name() docstrings
sameh-farouk 9b0ae5d
docs: Upadting get_pid_by_port() and get_process_by_port() docstrings
sameh-farouk 635effd
feat: Adding new function kill_proc_tree()
sameh-farouk 3f04dd4
docs: Updating get_pids_filtered_sorted() docstring
sameh-farouk 8f1322d
feat: Adding logging to get_filtered_pids()
sameh-farouk d6db842
test: Updating get_user_processes() test
sameh-farouk 4e1c238
test: Updating get_user_processes() test
sameh-farouk cedd567
feat: Adding logging to get_user_processes()
sameh-farouk 7b81b36
feat: Adding logging to check_start()
sameh-farouk b9fd01b
docs: Updating kill_proc_tree() docstring
sameh-farouk 0d55415
refactor: modifiy kill_user_processes() to return Process objects
sameh-farouk 4fe0361
fix: Fixing get_processes_info() returns None
sameh-farouk afe15c2
fix: Restoring accidentally deleted? functionality for get_processes_…
sameh-farouk 8391903
feat: Adding logging to check_stop()
sameh-farouk 5bf9967
tests: Adding debuging code in test_process.py
sameh-farouk e1fd625
Adding Debug code investigating a build issue
sameh-farouk 5951865
fix: Fixing get_pids_filtered_sorted return process objects not list[…
sameh-farouk 161a215
fix: Fixing AttributeError raised from get_pids_filtered_sorted()
sameh-farouk a119f42
docs: Updating get_processes_info() docstring
sameh-farouk aae8120
fix: Updating default_predicate()
sameh-farouk e26de87
fix: Updating get_pids()
sameh-farouk 1860a71
docs: Re-generating docs
sameh-farouk 73f94a1
fix: Fixing test_22_get_sorted_pids
sameh-farouk b4c7812
Revert "fix: Updating default_predicate()"
sameh-farouk ec1a91b
tests: Fixing bug in test_process.get_process_pids()
sameh-farouk c3ee7e0
Update test_process.py
sameh-farouk 1bba426
tests: Fixing tests
sameh-farouk 01fe132
Merge branch 'development_sal_process_iss467' of https://github.com/t…
sameh-farouk a868221
tests: revert last merge
sameh-farouk 4feed66
tests: Fixing tests
sameh-farouk 0f4745d
tests: Fixing typo
sameh-farouk 6942536
tests: Fixing bug in getting username
sameh-farouk b89d225
feat: get_pids now ignoring zombie processes by default
sameh-farouk 708bf24
fix: change get_pids() default sort direction to Asc
sameh-farouk 4d007f1
docs: Updating get_pids() docstring
sameh-farouk d6a899a
tests: Fixing Defunct processes are reported with pgrep.
sameh-farouk 77cf0c6
tests: Fixing tests
sameh-farouk c0cccfe
tests: Fixing getting current user name (in portable way)
sameh-farouk b237380
Adding a new arg `full_cmd_line` to get_pids()
sameh-farouk 3be9009
tests: fixing test_12_get_processes_info
sameh-farouk 8dcc973
fix: Implementing _alt_source in get_pids()
sameh-farouk fcabc46
refactor: Removing debug code
sameh-farouk 178b1c2
refactor: Removing redundant code
sameh-farouk 3d859db
refactor: Updating the default_predicate()
sameh-farouk 5e4019d
refactor: split str command line using shlex.split() instead of str.s…
sameh-farouk 9c35b09
tests: quoting tmux start command arg
sameh-farouk 45d8b07
refacotr: Enhance get_pids() performance
sameh-farouk 30dd856
tests: excaping the backslash in the regex pattern
sameh-farouk 83556fe
Adding debuging code
sameh-farouk 349ef1b
tests: Adding exact arg to get_process_pids()
sameh-farouk c9d30f1
Add debugging code
sameh-farouk ff93b55
refactor: Adding delay arg to check_stop() and check_start()
sameh-farouk 0e786aa
tests: Disable match againest full cmdline when `exact` arg set to True
sameh-farouk 560ba69
docs: Addding examples in the module docstring
sameh-farouk e0b06d1
docs: completing and formating docstrings
sameh-farouk a0abf80
Removing some debug messages
sameh-farouk c628168
refactor: Adding timeout arg to check_stop() and check_start()
sameh-farouk 95dc897
refactor: Adding `sig` and `timeout` args to kill_user_processes()
sameh-farouk 09cd209
feat: Adding new function kill_all_pids()
sameh-farouk 6e7285a
refactor:Now kill() return `None` when succeed
sameh-farouk 8909ca4
refactor:Now check_start() return `None` when succeed
sameh-farouk 770813f
refactor:Now check_stop() return `None` when succeed
sameh-farouk 33ef341
tests: Adapting to Change in process.kill() return value
sameh-farouk 038ab08
tests: Adapting to Change in process.kill() return value
sameh-farouk 56e5d22
refactor:Now kill_process_by_port() doesn't expect return value from …
sameh-farouk d4903a6
refactor: Simplifying long ternary operator statement as suggested by…
sameh-farouk 2c32fb0
fix: Removing misplaced and redundant try/except
sameh-farouk b56960a
refactor: Removing redundant debug message
sameh-farouk fc1e190
refactor:kill_all() now deprecated and removed in favor of kill_proce…
sameh-farouk 9e32165
tests: Adapting and replacing kill_all() with kill_process_by_name()
sameh-farouk d155eb3
fix:change default `die` arg value to False for get_process_object()
sameh-farouk 7ada6dd
refactor: Updating set_env_var() remove redundant try/except statment
sameh-farouk eda33d9
Docs: Updating docstring
sameh-farouk 3fd9adf
Docs: Updating get_suer_processes() docstring
sameh-farouk 0f0f617
refactor: Raising proper exception type
sameh-farouk 16dd253
fix: Skipping a test that require root privileges, if user is not root
sameh-farouk 83db70b
refactor: apply a suggested change
sameh-farouk 530bfd6
more cleanup with @sameh-farouk
abom 17247d6
simplify get_pids predicate matching for processes
abom File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
refactor: Refactoring set_env_var()
- renaming args to more readable names. - Updating the docstring.
- Loading branch information
commit 4c2964e7bec6ce4cbcbe56da976fbdc1c687d12a
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.