Skip to content

Various fixes on GitHub Actions CI #3933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

yutannihilation
Copy link
Member

@yutannihilation yutannihilation commented Apr 8, 2020

This PR addresses the following issues:

@yutannihilation yutannihilation changed the title Various fixes on GitHub Actions CI WIP: Various fixes on GitHub Actions CI Apr 8, 2020
@yutannihilation yutannihilation changed the title WIP: Various fixes on GitHub Actions CI Various fixes on GitHub Actions CI Apr 18, 2020
@yutannihilation
Copy link
Member Author

@clauswilke @thomasp85
This PR is ready and will fix the current CI failure on macOS w/ R-devel. Could any of you approve this?

# if: matrix.config.os == 'macOS-latest' && matrix.config.r == '3.6'
# run: covr::codecov()
# shell: Rscript {0}
- name: Test coverage
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be worthwhile to remove in favour of a separate action (that's what we're using elsewhere)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, sounds nice! I'll remove this step and add https://github.com/r-lib/actions/blob/master/.github/workflows/test-coverage.yaml.

@yutannihilation yutannihilation merged commit c7f9398 into tidyverse:master Apr 19, 2020
@yutannihilation yutannihilation deleted the ci/issue-3921-tweak-github-actions branch April 19, 2020 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants