Skip to content

Conversation

@koushiro
Copy link
Contributor

Signed-off-by: koushiro [email protected]

  • update some dependencies
  • use thiserror intead of quick-error for error handling
  • make clippy happy

@Fullstop000 Fullstop000 requested a review from hicqu September 15, 2020 02:48
Copy link
Member

@Fullstop000 Fullstop000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hicqu
Copy link
Contributor

hicqu commented Sep 15, 2020

@koushiro thanks! Could you resolve the conflict? And have you tried to compile the branch with TiKV master?

@koushiro
Copy link
Contributor Author

@koushiro thanks! Could you resolve the conflict? And have you tried to compile the branch with TiKV master?

Yeah, I have tried it.
But the changes of MemTableAccessor::new caused the CI fail 😕

@hicqu hicqu merged commit b38b170 into tikv:master Sep 17, 2020
@koushiro koushiro deleted the koushiro/update branch September 17, 2020 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants