Skip to content

README.md: update versions, fix typos #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 27, 2021

Conversation

kolyshkin
Copy link

Currently, the example uses @v.0.1.0 version of this package,
and @master of get-pr-commits. This is obviously wrong, since
v.0.1.0 is not working with the parameters in the example.

Fix the example using last released versions, and fix some typos
while we're at it.

Currently, the example uses `@v.0.1.0` version of this package,
and `@master` of get-pr-commits. This is obviously wrong, since
v.0.1.0 is not working with the parameters in the example.

Fix the example using last released versions, and fix some typos
while we're at it.
Copy link

@Tim-Zhang Tim-Zhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kolyshkin good catch, thank you very much.

@Tim-Zhang Tim-Zhang merged commit 44e2d29 into tim-actions:master Jan 27, 2021
kolyshkin added a commit to kolyshkin/commit-message-checker-with-regex that referenced this pull request Jun 2, 2021
In my previous PR tim-actions#1
I made a mistake of using `v1.0.0` instead of `v0.1.0` in one place. This PR fixes that.

PS can you please enable "Issues" for this repo? I want to report a problem but can't;
thus I am reporting it below.

-----

-- there is a
tag 'v1' in this repo (https://github.com/tim-actions/commit-message-checker-with-regex/releases/tag/v1)
which I think needs to be removed as the latest version is v0.3.1 and v1 > v0,
so dependabot suggest to update from v0.3.1 to v1 which is obviously wrong.

To fix this, `v1` tag need to be removed.

Alternatively, you can release say v1.1 or so and that will fix the issue
(an update to README.md is required).
@kolyshkin kolyshkin mentioned this pull request Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants