Made callbacks optional for async functions #430
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lobabob
changed the title
lobabob
changed the title
|
Changed it to a draft, hadn't run tests or linting myself yet. Need to clean this up a bit first. |
lobabob
changed the title
|
There we go. Addressed any linting issues and updated the tests. |
|
@lobabob when you get a chance, can you fix up the formatting, otherwise, I think this should be good to go. |
|
Went ahead and addressed the formatting issue. Forgot to remove the unused promisify import earlier 😅 |
|
Hmmm.... Looks like these changes have exposed some type issues in your tests that were swallowed by promisify before. |
|
Looks like everything is passing. You should be good to merge it unless you see any other issues with it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #429