Define Cross Domain Allow Headers To Be Set For The API #216
Conversation
…d by ajax calls from Javascript. Cors settings are set from laravel-echo-server.json file. Ran into a situation where I need this and fixed it manually but that's not a long term fix.
Changed amount of options passed to only be CORS settings so that keys are not passed to public API and prevent access to them from it.
Change to only send CORS settings to API class to avoid sending keys to public facing interface and avoid exploits of them.
abetwothree
changed the title
The explanation of how to use the CORS settings in laravel-echo-server.json file.
abetwothree
changed the title
|
Hi @tlaverdure I wrote up some features in my Laravel app that uses this feature and I've been manually adding this to my install of the echo server but my teammates are now needing this too. No rush cause I know we all got personal lives and this is free project you work on your free time. Just wanted to get an idea and if I can be of any help let me know for sure! Thanks! |
|
Hi guys! I'm also working with an SPA there I really need this pull request :-) Thank you for the great job in this project! |
|
As it seems, this repo is not very active anymore... there is a fork I'm currently using:https://github.com/dantecoding/laravel-echo-server You can clone, rename the package in package.json, npm publish it and install it as long, as this repo doesn't get any more love... |
|
Oh, thanks! |
|
I will be reviewing this soon. Sorry for the delay. |
|
@okaufmann a little harsh! @tlaverdure does a great job with echo server. Having multiple forks around the place isn't all that helpful IMHO. |
|
Of course too fussy @jonnywilliamson your right, I didn't want to deny the good work in any way. |
|
I also think @tlaverdure did and does a great job with this project. Though I must admit, this feature seems to have good public demand 😄 |
|
Published at 1.3.2. Thanks for your patience. |
|
@tlaverdure Thank you very much for the good work with this project. Amazing!! |
5 participants
Added a fix to allow AJAX calls to ping the API from either same domain different port, or totally different domain. CORS settings are set from laravel-echo-server.json file. Ran into a situation where I needed this and fixed it manually but that's not a long term fix, so I decided to make a fork and pull request with this feature.
Thank you for looking into and hopefully integrating it with the system.
Thanks!