Set --help usage line to match node client #149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current usage text for the client is:
This works, but is cumbersome to add more options to as the string is manually configured, and making sure the flags match their string, etc.
The switch for using the manually created string instead of relying on argparse was done in #116, with the reason that
commandwould show up as optional and many part ([command, ...]) because of thenargs='*'on it. This is confusing though ascommandis only optional when using--update_cache, and then otherwise required. Hence the manually set string.The node client on the other hand does:
This is preferable imo to our current approach as we then let argparse to show our options below automatically and we should never have to touch the usage string again.