Skip to content

Change non-word regex to be POSIX compliant #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 27, 2022

Conversation

stevejbrown
Copy link
Contributor

Fixes #194

This makes the regex compatible with both BSD and GNU versions of sed.

This makes the regex compatible with BSD and GNU versions of sed.
@tansiret tansiret self-assigned this Oct 30, 2022
Copy link
Member

@tansiret tansiret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it tested if this breakes the Windows version?

@stevejbrown
Copy link
Contributor Author

Thanks for the question @YUTYO! I have not tested on Windows. I don't typically develop on it, but my understanding is that there are typically two ways to get sed on Windows:

  1. An installed linux distribution via Windows Subsystem for Linux
  2. As part of Cygwin

I think both of these options would use the GNU flavor of sed.

@MasterOdin MasterOdin merged commit 8e6ea51 into tldr-pages:main Dec 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Autocomplete not working on macOS
4 participants