Notice other versions of the same page #208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For instance, inform if a linux page is also in common.
Co-authored-by: CleanMachine1 <[email protected]>
vitorhcl
previously requested changes
Jan 30, 2024
|
I ran black on the script |
|
I reverted black formatting to not conflict with other PRs for now. We can maybe run it in another PR |
vitorhcl
requested review from
owenvoke and
kbdharun
and removed request for
kbdharun
Signed-off-by: K.B.Dharun Krishna <[email protected]>
kbdharun
approved these changes
Jun 5, 2024
vitorhcl
reviewed
Jun 5, 2024
Signed-off-by: K.B.Dharun Krishna <[email protected]>
kbdharun
approved these changes
Jun 6, 2024
vitorhcl
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #193
This PR changes the way pages are searched so that it can find multiple versions of the same page. Therefore, every time a page is searched, every possible platform is checked even if a previous valid one was found. If more than one page is found, the next platform in the priority list is noticed to the user.
It doesn't search in every page if the platform was determined by the user parameters.
The PR implements this specification.
Bugs: it wont find multiple versions of the page if the cache only contains one of them. As it's much faster to search on the cache, this bug was not resolved.