Skip to content

Update installation methods in README.rst and in docs/quickstart.rst #681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 14, 2021

Conversation

jvcarli
Copy link
Contributor

@jvcarli jvcarli commented Jun 10, 2021

Update the relevant files with Homebrew installation method now that tmuxp is in Homebrew/homebrew-core@aff29be.

@tony tony merged commit d108625 into tmux-python:master Jun 14, 2021
@tony
Copy link
Member

tony commented Jun 14, 2021

@jvcarli Also shouted this out in our CHANGES file :)

@tony
Copy link
Member

tony commented Jun 14, 2021

Now that tmuxp 1.8.0 is out we probably should update homebrew for that :)

I made a post release on pypi to make sure its in the README and changelog.

@jvcarli
Copy link
Contributor Author

jvcarli commented Jun 14, 2021

I tried to update the formula and it was surprisingly easy.

The process:

  1. brew bump tmuxp, which shows the latest available version of the package and if there's any open pull request for bumping the formula. The output:

    Current formula version:  1.7.2
    Latest Repology version:  1.7.2
    Latest livecheck version: 1.8.0.post0
    Open pull requests: none
    
  2. brew bump-formula-pr --strict tmuxp --version=1.8.0.post0 to update the formula and send a pull request to homebrew-core automatically.

However, I hadn't done 2 yet because I wanted to test the formula update locally. The package builds as expected, but the assert test fails because it tries to match 1.8.0.post0 (which is used to make tmuxp local directory, I think Homebrew gets this from PyPI) against 1.8.0post0 (without the dot before post) from tmuxp --version.

The other tests were successful.

This is almost nitpicking but it will make the tests fail in Homebrew CI and the formula update won't be accepted. How do you want to deal with this @tony? I don't think this test is necessarily bad, although is not specially useful for checking if tmuxp works correctly when installed with Homebrew, so I could remove it from the formula or you could update __version__ in __about.py__.

@tony
Copy link
Member

tony commented Jun 14, 2021

@jvcarli

I will publish 1.8.1 for now. Standby

tony added a commit that referenced this pull request Jun 14, 2021
See also: #681 issue with homebrew
@tony
Copy link
Member

tony commented Jun 14, 2021

@jvcarli 1.8.1 is live. Better now?

@jvcarli
Copy link
Contributor Author

jvcarli commented Jun 14, 2021

@tony Everything's working!

@jvcarli
Copy link
Contributor Author

jvcarli commented Jun 14, 2021

I had some issues with git trying to bump the formula automatically using brew bump-formula-pr --strict tmuxp --version=1.8.1. Tomorrow I'll fix then and submit a PR to homebrew-core.

@tony
Copy link
Member

tony commented Jun 14, 2021

@jvcarli Sounds like a plan!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants