Skip to content

Refactoring #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nochso opened this issue Jan 15, 2016 · 2 comments
Closed

Refactoring #72

nochso opened this issue Jan 15, 2016 · 2 comments
Labels
enhancement
Milestone
v0.8.0

Comments

@nochso
Copy link
Contributor

nochso commented Jan 15, 2016

Hi. This is such a great tool and I'd like it to become easier to use.

I've started to refactor the CompareCommand so re-use should become much simpler. Meaning the git checker can be simplified afterwards.

Mixing file configuration and CLI arguments is what I'm also working on. I'll send a PR when it's ready.
This was referenced Jan 16, 2016
Closed
Closed
@nochso
Copy link
Contributor Author

nochso commented Jan 17, 2016

I've started over as there were too many unrelated changes at once. I'll try refactoring a bit more atomically so merging doesn't become an issue.

@nochso nochso mentioned this issue Jan 17, 2016
Merged
@tomzx
Copy link
Owner

tomzx commented Jan 23, 2016

I'll consider that since #74 has been merged, this can be closed. If not, let me know and I'll reopen.

@tomzx tomzx closed this as completed Jan 23, 2016
@tomzx tomzx assigned tomzx and unassigned tomzx Jan 23, 2016
@tomzx tomzx added this to the v0.8.0 milestone Jan 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
v0.8.0
Development

No branches or pull requests
2 participants
@tomzx @nochso