Refactoring for easier reuse, merge CLI and config #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nochso
changed the title
|
Thanks for the feedback. Should I push fixes to this PR, rewrite this one or create a new clean PR..? |
|
I think it's generally usage on github to simply rebase your work (aka overwrite what you've done so far and simply push on the same branch which should update this PR). |
nochso
force-pushed
the
refactor
branch
2 times, most recently
from
60213c2 to
9ee2af8
Compare
|
Ok, I reworked the PR. Merging is now done by an InputMerger. |
|
I'll give this a test run and I'll try to merge this within the day. Thanks for the work! |
|
Thanks again! |
Closed
|
Great, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #72
Mostly trying to shrink down all the boiler-plate in CompareCommand's
executemethod.What do you think so far? @tomzx
See commit "Merge configuration and CLI input" for implementing #67.