Skip to content

Conversation

deronnax
Copy link
Contributor

@deronnax deronnax commented Feb 3, 2024

  • change http scheme for https for two urls
  • fix typing for overriden getuid (not 100% sure about this one)
  • fix what looks like to me as a grammar error in a comment

@deronnax
Copy link
Contributor Author

deronnax commented Feb 3, 2024

looks like the 2nd link is dead, unfortunately. Redirects to Microsoft's general support homepage:

$ curl -sLI https://support.microsoft.com/default.aspx\?scid\=kb\;en-us\;310294\#XSLTH3194121123120121120120 | egrep '(HTTP|location)'
HTTP/2 301
location: https://support.microsoft.com/?scid=kb;en-us;310294
HTTP/2 301
location: https://support.microsoft.com/en-US
HTTP/2 200

@ofek
Copy link
Collaborator

ofek commented Feb 4, 2024

Would it be this? https://learn.microsoft.com/en-us/windows/win32/shell/knownfolderid

@gaborbernat gaborbernat merged commit 1aece7e into tox-dev:main Feb 13, 2024
alicejli referenced this pull request in googleapis/sdk-platform-java May 3, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [platformdirs](https://togithub.com/platformdirs/platformdirs) |
`==4.1.0` -> `==4.2.1` |
[![age](https://developer.mend.io/api/mc/badges/age/pypi/platformdirs/4.2.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/pypi/platformdirs/4.2.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/pypi/platformdirs/4.1.0/4.2.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/pypi/platformdirs/4.1.0/4.2.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>platformdirs/platformdirs (platformdirs)</summary>

###
[`v4.2.1`](https://togithub.com/platformdirs/platformdirs/releases/tag/4.2.1)

[Compare
Source](https://togithub.com/platformdirs/platformdirs/compare/4.2.0...4.2.1)

<!-- Release notes generated using configuration in .github/release.yml
at main -->

#### What's Changed

- Switch to ruff for formatting and use codespell and docformatter by
[@&#8203;gaborbernat](https://togithub.com/gaborbernat) in
[https://github.com/platformdirs/platformdirs/pull/261](https://togithub.com/platformdirs/platformdirs/pull/261)
- Use hatch over tox by
[@&#8203;gaborbernat](https://togithub.com/gaborbernat) in
[https://github.com/platformdirs/platformdirs/pull/262](https://togithub.com/platformdirs/platformdirs/pull/262)
- chore: various minor fixes by
[@&#8203;deronnax](https://togithub.com/deronnax) in
[https://github.com/platformdirs/platformdirs/pull/263](https://togithub.com/platformdirs/platformdirs/pull/263)
- chore: update dead Microsoft's known folders documentation link by
[@&#8203;deronnax](https://togithub.com/deronnax) in
[https://github.com/platformdirs/platformdirs/pull/267](https://togithub.com/platformdirs/platformdirs/pull/267)
- Allow working without ctypes by
[@&#8203;youknowone](https://togithub.com/youknowone) in
[https://github.com/platformdirs/platformdirs/pull/275](https://togithub.com/platformdirs/platformdirs/pull/275)

#### New Contributors

- [@&#8203;deronnax](https://togithub.com/deronnax) made their first
contribution in
[https://github.com/platformdirs/platformdirs/pull/263](https://togithub.com/platformdirs/platformdirs/pull/263)
- [@&#8203;youknowone](https://togithub.com/youknowone) made their first
contribution in
[https://github.com/platformdirs/platformdirs/pull/275](https://togithub.com/platformdirs/platformdirs/pull/275)

**Full Changelog**:
tox-dev/platformdirs@4.2.0...4.2.1

###
[`v4.2.0`](https://togithub.com/platformdirs/platformdirs/releases/tag/4.2.0)

[Compare
Source](https://togithub.com/platformdirs/platformdirs/compare/4.1.0...4.2.0)

<!-- Release notes generated using configuration in .github/release.yml
at main -->

#### What's Changed

- Fix 2 typos about XDG_DATA_DIR by
[@&#8203;Freed-Wu](https://togithub.com/Freed-Wu) in
[https://github.com/platformdirs/platformdirs/pull/256](https://togithub.com/platformdirs/platformdirs/pull/256)
- Add convenience methods to `PlatformDirsAPI` that allow iterating over
both user and site dirs/paths. by
[@&#8203;SpaceshipOperations](https://togithub.com/SpaceshipOperations)
in
[https://github.com/platformdirs/platformdirs/pull/258](https://togithub.com/platformdirs/platformdirs/pull/258)

#### New Contributors

-
[@&#8203;SpaceshipOperations](https://togithub.com/SpaceshipOperations)
made their first contribution in
[https://github.com/platformdirs/platformdirs/pull/258](https://togithub.com/platformdirs/platformdirs/pull/258)

**Full Changelog**:
tox-dev/platformdirs@4.1.0...4.2.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/googleapis/sdk-platform-java).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMDEuNCIsInVwZGF0ZWRJblZlciI6IjM3LjMxMy4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->

Co-authored-by: Alice <[email protected]>
lqiu96 referenced this pull request in googleapis/sdk-platform-java May 22, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [platformdirs](https://togithub.com/platformdirs/platformdirs) |
`==4.1.0` -> `==4.2.1` |
[![age](https://developer.mend.io/api/mc/badges/age/pypi/platformdirs/4.2.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/pypi/platformdirs/4.2.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/pypi/platformdirs/4.1.0/4.2.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/pypi/platformdirs/4.1.0/4.2.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>platformdirs/platformdirs (platformdirs)</summary>

###
[`v4.2.1`](https://togithub.com/platformdirs/platformdirs/releases/tag/4.2.1)

[Compare
Source](https://togithub.com/platformdirs/platformdirs/compare/4.2.0...4.2.1)

<!-- Release notes generated using configuration in .github/release.yml
at main -->

#### What's Changed

- Switch to ruff for formatting and use codespell and docformatter by
[@&#8203;gaborbernat](https://togithub.com/gaborbernat) in
[https://github.com/platformdirs/platformdirs/pull/261](https://togithub.com/platformdirs/platformdirs/pull/261)
- Use hatch over tox by
[@&#8203;gaborbernat](https://togithub.com/gaborbernat) in
[https://github.com/platformdirs/platformdirs/pull/262](https://togithub.com/platformdirs/platformdirs/pull/262)
- chore: various minor fixes by
[@&#8203;deronnax](https://togithub.com/deronnax) in
[https://github.com/platformdirs/platformdirs/pull/263](https://togithub.com/platformdirs/platformdirs/pull/263)
- chore: update dead Microsoft's known folders documentation link by
[@&#8203;deronnax](https://togithub.com/deronnax) in
[https://github.com/platformdirs/platformdirs/pull/267](https://togithub.com/platformdirs/platformdirs/pull/267)
- Allow working without ctypes by
[@&#8203;youknowone](https://togithub.com/youknowone) in
[https://github.com/platformdirs/platformdirs/pull/275](https://togithub.com/platformdirs/platformdirs/pull/275)

#### New Contributors

- [@&#8203;deronnax](https://togithub.com/deronnax) made their first
contribution in
[https://github.com/platformdirs/platformdirs/pull/263](https://togithub.com/platformdirs/platformdirs/pull/263)
- [@&#8203;youknowone](https://togithub.com/youknowone) made their first
contribution in
[https://github.com/platformdirs/platformdirs/pull/275](https://togithub.com/platformdirs/platformdirs/pull/275)

**Full Changelog**:
tox-dev/platformdirs@4.2.0...4.2.1

###
[`v4.2.0`](https://togithub.com/platformdirs/platformdirs/releases/tag/4.2.0)

[Compare
Source](https://togithub.com/platformdirs/platformdirs/compare/4.1.0...4.2.0)

<!-- Release notes generated using configuration in .github/release.yml
at main -->

#### What's Changed

- Fix 2 typos about XDG_DATA_DIR by
[@&#8203;Freed-Wu](https://togithub.com/Freed-Wu) in
[https://github.com/platformdirs/platformdirs/pull/256](https://togithub.com/platformdirs/platformdirs/pull/256)
- Add convenience methods to `PlatformDirsAPI` that allow iterating over
both user and site dirs/paths. by
[@&#8203;SpaceshipOperations](https://togithub.com/SpaceshipOperations)
in
[https://github.com/platformdirs/platformdirs/pull/258](https://togithub.com/platformdirs/platformdirs/pull/258)

#### New Contributors

-
[@&#8203;SpaceshipOperations](https://togithub.com/SpaceshipOperations)
made their first contribution in
[https://github.com/platformdirs/platformdirs/pull/258](https://togithub.com/platformdirs/platformdirs/pull/258)

**Full Changelog**:
tox-dev/platformdirs@4.1.0...4.2.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/googleapis/sdk-platform-java).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMDEuNCIsInVwZGF0ZWRJblZlciI6IjM3LjMxMy4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->

Co-authored-by: Alice <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants