Skip to content

feat(sdk): allow disabling prompt sending as argument to Traceloop.init() #1620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

liamjdavis
Copy link

  • I have added tests that cover my changes.
  • If adding a new instrumentation or changing an existing one, I've added screenshots from some observability platform showing the change.
  • PR name follows conventional commits format: feat(instrumentation): ... or fix(instrumentation): ....
  • (If applicable) I have updated the documentation accordingly.

@CLAassistant
Copy link

CLAassistant commented Jul 21, 2024

CLA assistant check
All committers have signed the CLA.

@liamjdavis liamjdavis changed the title feat(sdk): allow disablign prompt sending as argument to Traceloop.init() feat(sdk): allow disabling prompt sending as argument to Traceloop.init() Jul 23, 2024
Copy link
Member

@nirga nirga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @liamjdavis! I have to say I'm less of a fan of changing an environment for a user - this may have some unexpected results. I think a better solution is to add this to the configuration of all instrumentations and then pass the value during initialization, like we do here:

instrumentor = OpenAIInstrumentor(

@liamjdavis
Copy link
Author

@nirga I have started changing it to changing the configuration of all instrumentation, but I am unsure of what to change in the configurations, particularly where the only parameter beyond what's in the BaseInstrumentor is the exception_logger. Can you help me here?

@nirga
Copy link
Member

nirga commented Jul 26, 2024

@liamjdavis you should add a new parameter to the instrumentations which controls whether prompt sending is enabled or disabled.

@liamjdavis
Copy link
Author

Thank you, I'll start working on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants