fix(milvus): Added New Semantic Conventions for Milvus Search (Request for Version Update 0.4.5 -> 0.4.6)

[divyapathak24]

Fixes #2808

• I have added tests that cover my changes.
• If adding a new instrumentation or changing an existing one, I've added screenshots from some observability platform showing the change.
• PR name follows conventional commits format: feat(instrumentation): ... or fix(instrumentation): ....
• (If applicable) I have updated the documentation accordingly.

---

Important

Added new semantic conventions for Milvus search and updated version to 0.4.6.

• Semantic Conventions:
  • Added new attributes to SpanAttributes in __init__.py for Milvus search: MILVUS_SEARCH_PARTITION_NAMES, MILVUS_SEARCH_QUERY_VECTOR_DIMENSION, MILVUS_SEARCH_RESULT_COUNT, MILVUS_SEARCH_RESULT_DISTANCES, MILVUS_SEARCH_RESULT_TOP_IDS.
• Version Update:
  • Updated version to 0.4.6 in version.py and pyproject.toml.

^{This description was created by for 8555248. You can customize this summary. It will automatically update as commits are pushed.}

[ellipsis-dev]

Important

Looks good to me! 👍

Reviewed everything up to 8555248 in 51 seconds. Click for details.

• Reviewed 37 lines of code in 3 files
• Skipped 0 files when reviewing.
• Skipped posting 6 draft comments. View those below.
• Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.

1. packages/opentelemetry-semantic-conventions-ai/opentelemetry/semconv_ai/__init__.py:196

• Draft comment:
  Added new Milvus search attributes (partition_names, query_vector_dimension, result_count, result_distances, result_top_ids). Ensure the documentation is updated to reflect these conventions.
• Reason this comment was not posted:
  Confidence changes required: 0% <= threshold 50% None

2. packages/opentelemetry-semantic-conventions-ai/opentelemetry/semconv_ai/version.py:1

• Draft comment:
  Version bump to 0.4.6 is consistent with changes. Confirm that dependent projects are updated.
• Reason this comment was not posted:
  Confidence changes required: 0% <= threshold 50% None

3. packages/opentelemetry-semantic-conventions-ai/pyproject.toml:11

• Draft comment:
  Pyproject.toml version updated to 0.4.6. Ensure that package metadata aligns with the changes.
• Reason this comment was not posted:
  Confidence changes required: 0% <= threshold 50% None

4. packages/opentelemetry-semantic-conventions-ai/opentelemetry/semconv_ai/__init__.py:194

• Draft comment:
  New Milvus search constants (PARTITION_NAMES, QUERY_VECTOR_DIMENSION, RESULT_COUNT, RESULT_DISTANCES, RESULT_TOP_IDS) are added and follow the naming pattern. Consider adding inline documentation or cross-reference to the feature issue for clarity.
• Reason this comment was not posted:
  Confidence changes required: 33% <= threshold 50% None

5. packages/opentelemetry-semantic-conventions-ai/opentelemetry/semconv_ai/version.py:1

• Draft comment:
  Version bump from 0.4.5 to 0.4.6 looks correct.
• Reason this comment was not posted:
  Comment did not seem useful. Confidence is useful = 0% <= threshold 50% This comment is purely informative and does not provide any actionable feedback or suggestions. It simply states that the version bump looks correct, which is not necessary for the PR author to know.

6. packages/opentelemetry-semantic-conventions-ai/pyproject.toml:11

• Draft comment:
  The version in pyproject.toml is updated to 0.4.6 consistently with the version.py change.
• Reason this comment was not posted:
  Comment did not seem useful. Confidence is useful = 0% <= threshold 50% This comment is purely informative and does not provide any actionable feedback or suggestions. It simply acknowledges a change that was made, which violates the rule against making purely informative comments.

Workflow ID: wflow_8dTtgBVF4rXRRCRf

^{You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.}

[divyapathak24]

@nirga @galkleinman Added new milvus search attributes

[nirga]

@divyapathak24 shouldn't we reuse existing attributes - so that we'll have the same attribute across vector DBs?

[divyapathak24]

@nirga That makes sense. However, we don't currently have a results_count and query_vector_dimension attribute in EventAttributes. I'll add it so we can use it consistently for all DB events.

cc:@hk-bmi

[divyapathak24]

@nirga Reusing DB_QUERY* events and event attributes to represent search operation can be misleading, both are different operations. So, I introduced the DB_SEARCH* fields. These are intended to generically support search functionality across different vector DBs as well.

[divyapathak24]

These are better suited as span attributes since the result count serves as a summary of the overall search outcome, and the query vector dimension represents input query and is not part of the output.

[nirga]

hey @divyapathak24 can you fix the lint issues?

[divyapathak24]

hey @divyapathak24 can you fix the lint issues?

@nirga Done