Skip to content

Conversation

@ahlinc
Copy link
Contributor

@ahlinc ahlinc commented Aug 17, 2023

All issues that were reasons to stick on specific fixture versions are resolved.
The javascript grammar uses partial order precedences on the master branch.

@amaanq
Copy link
Member

amaanq commented Aug 17, 2023

seems like js changed a bit w/ string nodes

@ahlinc ahlinc marked this pull request as draft August 17, 2023 22:26
@ahlinc

This comment was marked as outdated.

@ahlinc
Copy link
Contributor Author

ahlinc commented Aug 17, 2023

With:

cd tree-sitter-javascript
ln -sf ../../../tree-sitter.origin/test/fixtures/error_corpus/javascript_errors.txt test/corpus/
tree-sitter test

It's seen that there're needed two trivial fixes:

Screenshot from 2023-08-18 01-45-08

@ahlinc ahlinc marked this pull request as ready for review August 17, 2023 22:47
@ahlinc ahlinc marked this pull request as draft August 18, 2023 01:29
@ahlinc ahlinc changed the title chore: switch all test fixtures on master branches chore: switch fetch-fixtures.cmd to all master branches Sep 21, 2023
@ahlinc ahlinc marked this pull request as ready for review September 21, 2023 08:29
@ahlinc ahlinc merged commit 6bbb50b into tree-sitter:master Sep 21, 2023
@ahlinc ahlinc deleted the use-fixture-masters branch September 21, 2023 09:32
@darker16

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants