Skip to content

Stop indexing the test-cloud domain #2026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 7, 2025

Conversation

samejr
Copy link
Member

@samejr samejr commented May 6, 2025

Prevents crawling of the test-cloud.trigger.dev subdomain. This is to fix Googling for "Trigger.dev login" showing test-cloud results.

Summary by CodeRabbit

  • Bug Fixes
    • Updated how search engine indexing is controlled, ensuring pages are only indexed when accessed via the "cloud.trigger.dev" domain.
  • Chores
    • Improved handling of meta tags and HTTP headers to better manage search engine visibility across different environments.

Copy link

changeset-bot bot commented May 6, 2025

⚠️ No Changeset found

Latest commit: b93608d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

coderabbitai bot commented May 6, 2025

Walkthrough

The changes update how the "robots" meta tag and the "X-Robots-Tag" HTTP header are set in the web application. Both now use runtime checks against the request hostname to determine whether to allow indexing by search engines, replacing previous logic based on server-side feature flags.

Changes

File(s) Change Summary
apps/webapp/app/root.tsx Updated logic for the "robots" meta tag to use runtime hostname checks instead of feature flags.
apps/webapp/server.ts Added conditional "X-Robots-Tag" header based on request hostname, set alongside security headers.

Suggested reviewers

  • ericallam

Poem

A bunny hopped across the cloud,
With headers set both firm and proud.
"Index, follow!" if you’re known—
Else, "noindex" seeds are sown.
Meta tags and headers, neat,
Keep search bots hopping on their feet!
🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 053389d and b93608d.

📒 Files selected for processing (2)
  • apps/webapp/app/root.tsx (1 hunks)
  • apps/webapp/server.ts (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (7)
  • GitHub Check: e2e / 🧪 CLI v3 tests (windows-latest - pnpm)
  • GitHub Check: e2e / 🧪 CLI v3 tests (windows-latest - npm)
  • GitHub Check: e2e / 🧪 CLI v3 tests (ubuntu-latest - pnpm)
  • GitHub Check: e2e / 🧪 CLI v3 tests (ubuntu-latest - npm)
  • GitHub Check: units / 🧪 Unit Tests
  • GitHub Check: typecheck / typecheck
  • GitHub Check: Analyze (javascript-typescript)
🔇 Additional comments (2)
apps/webapp/server.ts (1)

67-70: LGTM: Correctly implements X-Robots-Tag header for non-production domains.

The implementation adds the X-Robots-Tag header with "noindex, nofollow" value for all hostnames except "cloud.trigger.dev". This aligns with the PR objective to prevent web crawlers from indexing non-production domains, including test-cloud.trigger.dev.

apps/webapp/app/root.tsx (1)

43-46: LGTM: Consistent robots meta tag implementation.

The change to the robots meta tag logic properly handles both server-side and client-side rendering scenarios. Using typeof window === "undefined" for server-side detection is a good approach, and the hostname check matches the server-side implementation. This ensures consistent SEO directives across both HTTP headers and HTML meta tags.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@matt-aitken matt-aitken merged commit e94558a into main May 7, 2025
12 checks passed
@matt-aitken matt-aitken deleted the prevent-test-cloud-domain-indexing branch May 7, 2025 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants