feat(jsonrpc): check maxSubTopics and maxBlockRange to be consistent with eth #6271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waynercheung
force-pushed
the
feat/harden_filters
branch
2 times, most recently
from
51de3ea to
818602c
Compare
waynercheung
force-pushed
the
feat/harden_filters
branch
from
818602c to
fd89088
Compare
kuny0707
approved these changes
Apr 1, 2025
CodeNinjaEvan
approved these changes
Apr 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
check maxSubTopics and maxBlockRange to be consistent with eth.
Why are these changes required?
Add maxSubTopics and maxBlockRange to be consistent with eth.
This PR has been tested by:
Follow up
Extra details
check maxSubTopics for
eth_newFilterandeth_getLogs.check maxBlockRange for
eth_getLogs.