Exclude Node.js typings #112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If you can get this upstreamed into the main typescript template for RN, I'm game for it - https://github.com/react-native-community/react-native-template-typescript/blob/main/template/tsconfig.json Until then, I'd like to keep this closer to what is provided out of the box |
|
@orta I've already create a PR to official template react-native-community/react-native-template-typescript#272 |
|
@orta PR was accepted |
|
Cool, I've also bumped it to version 2 because something like this shouldn't happen in a patch release and its good to go |
|
Will get deployed on tomorrows scheduler |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #110
Before:
After: