Skip to content

Conversation

sbansla
Copy link
Contributor

@sbansla sbansla commented Jun 10, 2025

Fixes

Issue: phone number update command tries to install ngrok dependency and create a tunnel if localhost/127.0.01 URL us passed, tunnel creation used to fail.
Fix: Removed ngrok and incase localhost/127.0.01 is passed phone number update command with throw exception.

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

manisha1997
manisha1997 previously approved these changes Jun 10, 2025
@sbansla sbansla dismissed stale reviews from manisha1997 and tiwarishubham635 via 7d7fd90 June 12, 2025 06:59
@manisha1997 manisha1997 merged commit b20b8f4 into main Jun 13, 2025
7 of 10 checks passed
@manisha1997 manisha1997 deleted the remove-ngrok-dependency-2 branch June 13, 2025 06:37
twilio-dx pushed a commit that referenced this pull request Jun 13, 2025
## [6.0.0-rc.1](5.23.1...6.0.0-rc.1) (2025-06-13)

### ⚠ BREAKING CHANGES

* RC Release commit

### Library - Features

* rc-release commit ([#644](#644)) ([e747fd6](e747fd6))
* Update UPGRADE.md ([#645](#645)) ([9869d74](9869d74))

### Library - Fixes

* removed ngrok dependecy ([#635](#635)) ([b20b8f4](b20b8f4))

### Library - Chores

* Add rollback.yaml ([#625](#625)) ([5cd0035](5cd0035))
* Create rollback.yaml ([#627](#627)) ([e49dd51](e49dd51))
* node lts version set ([#636](#636)) ([cef5e9c](cef5e9c))
* release test ([#629](#629)) ([9167d28](9167d28))
* test with rc version ([02d5730](02d5730))
* test with rc version ([929f204](929f204))
* test with rc version ([3dd6710](3dd6710))
* update cli-core version ([b3b0b01](b3b0b01))
* update readme ([#637](#637)) ([e50de64](e50de64))
* Update rollback.yaml ([#628](#628)) ([d5e248a](d5e248a))
* Upgrade guide node 20 ([#638](#638)) ([2d41ce9](2d41ce9))
* upgrade node version ([#622](#622)) ([f83089f](f83089f))
twilio-dx pushed a commit that referenced this pull request Jun 24, 2025
## [6.0.0](5.23.1...6.0.0) (2025-06-24)

### ⚠ BREAKING CHANGES

* node 20 update

### Library - Features

* Breaking change commit ([#651](#651)) ([e7d15dd](e7d15dd))

### Library - Fixes

* removed ngrok dependecy ([#635](#635)) ([b20b8f4](b20b8f4))

### Library - Chores

* Add rollback.yaml ([#625](#625)) ([5cd0035](5cd0035))
* Create rollback.yaml ([#627](#627)) ([e49dd51](e49dd51))
* node lts version set ([#636](#636)) ([cef5e9c](cef5e9c))
* release ([#652](#652)) ([99fb955](99fb955))
* release test ([#629](#629)) ([9167d28](9167d28))
* update cli-core version ([a1f54d9](a1f54d9))
* update readme ([#637](#637)) ([e50de64](e50de64))
* Update rollback.yaml ([#628](#628)) ([d5e248a](d5e248a))
* Upgrade guide node 20 ([#638](#638)) ([2d41ce9](2d41ce9))
* upgrade node version ([#622](#622)) ([f83089f](f83089f))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Antivirus flagged virus when installing Twilio CLI for Windows
3 participants