Skip to content

feat(tweepcred): do not penalize until 1.0 friend-to-follower ratio #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

ctjlewis
Copy link

@ctjlewis ctjlewis commented Mar 31, 2023

Updates threshFriendsToFollowersRatioUMass 0.6 -> 1.0.

Currently, users are penalized >2500 following if their following-to-follower ratio exceeds 0.6. This is probably not appropriate, and it is more sensible to set this to 1.0.

twitter-team and others added 2 commits March 31, 2023 12:53
@ctjlewis
Copy link
Author

Note that this is an actual PR and not a joke one, would be good to get a review.

@Xetera
Copy link

Xetera commented Mar 31, 2023

I hope you're aware this was just elon's PR stunt (no pun intended) and Twitter has no intention of doing actual open source development on this repo

@ctjlewis
Copy link
Author

ctjlewis commented Mar 31, 2023

Thanks for that note @Xetera, though strangely enough I don't remember anyone asking you a GOD damn thing.

image

@JoshuaSkootsky
Copy link

This make sense.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@ctjlewis
Copy link
Author

@jdm-twtr - Trying to sign CLA but getting a rate limit error.

@yvesremmler
Copy link

As someone who follows many people out of curiosity, I agree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants