Skip to content

Fix !ts hat generation for overlapping ranges #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 23, 2022
Merged

Fix !ts hat generation for overlapping ranges #196

merged 1 commit into from
Feb 23, 2022

Conversation

tjjfvi
Copy link
Contributor

@tjjfvi tjjfvi commented Feb 21, 2022

No description provided.

@robertt
Copy link
Member

robertt commented Feb 22, 2022

Do you have an example of where this would be an issue?

@tjjfvi
Copy link
Contributor Author

tjjfvi commented Feb 22, 2022

Yep: https://discord.com/channels/508357248330760243/755409256290713681/945416717927055360

@robertt
Copy link
Member

robertt commented Feb 22, 2022

cool! just making sure, tested?

@ckiee ckiee enabled auto-merge (squash) February 22, 2022 15:27
@tjjfvi
Copy link
Contributor Author

tjjfvi commented Feb 22, 2022

Yep

ckiee
ckiee previously requested changes Feb 22, 2022
View reviewed changes
Copy link
Collaborator

@ckiee ckiee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpicks

@ckiee ckiee merged commit 77a7726 into typescript-community:master Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertt robertt robertt approved these changes

@ckiee ckiee ckiee left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tjjfvi @robertt @ckiee