Allow an optional language code in playground URLs #197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckiee
approved these changes
Feb 25, 2022
ckiee
force-pushed
the
handle-language-specific-playground-urls
branch
from
a8d1b6c to
199b022
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not entirely sure about the structure of such URLs, but tried a few things and noticed that things like
/es/and/fr/work, while/en-US/does not, so I'm guessing they're meant to be IETF BCP 47 "primary language subtags" without additional subtags. I could make the regex looser if we want to accept dashes/capital letters/longer language codes/other stuff in this path segment.