Skip to content

Allow !rep <id> #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 30, 2022
Merged

Allow !rep <id> #219

merged 1 commit into from
Oct 30, 2022

Conversation

Retsam
Copy link
Contributor

@Retsam Retsam commented Oct 29, 2022

Allows messages like Thanks @Alice and @Bob to give rep to both Alice and Bob - pretty sure the old system allowed this.
(EDIT: going to come back to this - more difficult than I thought)

Also implements #207 - could have worked this into the existing onThank logic (scan message for any ids, combine them with the list of mentioned user), but seemed simpler to implement it as a separate code path in the !rep command directly.

(Refactored out the basic giveRep logic into a helper, since this would be the third duplication)

@Retsam Retsam changed the title Allow multiple users to be repped in one mention / Allow !rep <id> Allow !rep <id> Oct 29, 2022
.fetch(targetMember)
.catch(() => null);
if (user) {
if (user.id === msg.author.id) return msg.react('🤡');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤡

@robertt robertt merged commit 7d64792 into typescript-community:master Oct 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants