Skip to content

Discord v14, farewell Cookiecord #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 5, 2022

Conversation

Gerrit0
Copy link
Contributor

@Gerrit0 Gerrit0 commented Nov 19, 2022

That took a while... now, on to forum help

@Gerrit0
Copy link
Contributor Author

Gerrit0 commented Nov 19, 2022

Note: Turning on hide whitespace in diffs is highly recommended

@@ -27,7 +27,7 @@ services:
volumes:
- 'postgres_data:/postgres/data'
ports:
- 5432
- 5432:5432
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not strictly necessary, but useful if you want to run the bot locally

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed this because it was giving me issues running this locally - seems like maybe we have mutually incompatible setups of some sort?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting... according to https://docs.docker.com/compose/compose-file/compose-file-v3/#ports, without :5432 Docker picks a random port, which would work around your port in use issue. I suspect the port was actually in use.

@@ -27,7 +27,7 @@ services:
volumes:
- 'postgres_data:/postgres/data'
ports:
- 5432
- 5432:5432
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed this because it was giving me issues running this locally - seems like maybe we have mutually incompatible setups of some sort?

ckiee
ckiee previously requested changes Nov 20, 2022
Copy link
Collaborator

@ckiee ckiee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few things I caught while seeing what a reverse migration looks like

@orta orta dismissed ckiee’s stale review December 5, 2022 06:53

Looks sorted to me

@orta orta merged commit e250206 into typescript-community:master Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants