[feature request] --watch with generate.js is broken after refactor

[syzer]

seriously? :)
again, will you accept pull request?

[typicode]

Sorry that you have problems with this feature.
It works for me on Linux at least:

module.exports = function () {
  return {
    foo: []
  }
}

json-server generate.js --watch

  \{^_^}/ hi!

  Loading generate.js
  Done

  Resources
  http://localhost:3000/foo

  Home
  http://localhost:3000

  Type s + enter at any time to create a snapshot of the database
  Watching...

  generate.js has changed, reloading...

  Loading generate.js
  Done

  Resources
  http://localhost:3000/bar

  Home
  http://localhost:3000

I've changed generate.js to:

module.exports = function () {
  return {
    bar: []
  }
}

And waited for something like 2-3 seconds.

What's your OS?

[syzer]

mac..

[typicode]

Ok thanks, will test on it :)

[syzer]

../../node_modules/.bin/json-server -w --routes=routes.json --port=3002 generate.js

[typicode]

Works too.

I'm on v0.7.23, that's strange.

[syzer]

i'm puzzled.. i'll jump on that

[syzer]

ok i figured out
we are not watching the directory (as it was before).. but file

please checkout my fork
git@github.com:syzer/json-server.git
and run
./bin/index.js --watch Trash/gen.js

changing id in Trash/other do not trigger reload

[typicode]

I understand better now. Thank you for the example :)
But right now, I prefer to keep watching a file instead of a directory.

Mainly for the sake of simplicity and to avoid side effects.
For example, considering this project structure:

/generate.js
/node_modules
/public/index.js

generate.js will be reloaded when a module is installed or when index.js is modified.
And I fear that in the end, nodemon will just be recoded in JSON Server.

So, instead as a workaround I would suggest this:

// server.js
var jsonServer = require('json-server')
var generate = require('./generate')

var router = jsonServer.router(generate())

var server = jsonServer.create()
server.use(jsonServer.defaults)
server.use(router)

server.listen(3000)

nodemon server

Or using node-touch:

// generate.js
fs.watch('./other', function () { touch(__filename) })

[syzer]

i made a fix for that to avoid workouraund, will you merge?

[typicode]

You mean this one 3443432?

[syzer]

Almost, ill push it tomorrow morning.

On Fri, Jul 31, 2015 at 8:53 PM, typicode notifications@github.com wrote:

You mean this one 3443432
3443432
?

—
Reply to this email directly or view it on GitHub
#160 (comment)
.

--Lukas 'SyZer' Gintowt

[syzer]

^^^ ?

[typicode]

Thanks for the PR, but I think it's a complex problem.
And I'm sorry not being able to pull.

Scenario 1

For example, I've cloned your repo and changed:

  // src/cli/watch.js
  fs.watch(watchedDir, {recursive: true}, function (event, changedFile) {
    // Atom text editor is generating a 'change' event
    // So with just 'rename' cb was not called
    // if (event === 'rename') cb()
    cb()
  })

Then I've created:

// db/generate.js
var other = require('./other')

module.exports = function () {
  return other()
}

// db/other.js
module.exports = function () {
  return { foo: [] }
}

And started JSON Server using:

node bin --watch db/generate.js

If other.js is changed:

// db/other.js
module.exports = function () {
  return { bar: [] }
}

generate.js will be reloaded but not other.js because it's cached by require() and there won't be a http://localhost:3000/bar route.

Scenario 2

Another complicated scenario is if you have the following project structure:

generate.js
other.js
public/index.html
public/index.js

public/index.js will be watched too. So when public/index.js is changed it will trigger a reload of generate.js even though it's not required by generate.js.

[syzer]

ad. Scenario 1
yes, it will be changed, because changing other.js will trigger reload of
generate, and other

did you made a branch for it?

ad. Scenario 2
if you have structure like this
either way you are doomed :)

so it doesn't really matters if you reload.

On Tue, Aug 4, 2015 at 4:57 PM, typicode notifications@github.com wrote:

Thanks for the PR, but I think it's a complex problem.
And I'm sorry not being able to pull.
Scenario 1

For example, I've cloned your repo and changed:

// src/cli/watch.js
fs.watch(watchedDir, {recursive: true}, function (event, changedFile) {
// Atom text editor is generating a 'change' event
// So with just 'rename' cb was not called
// if (event === 'rename') cb()
cb()
})

Then I've created:

// db/generate.jsvar other = require('./other')
module.exports = function () {
return other()
}

// db/other.jsmodule.exports = function () {
return { foo: [] }
}

And started JSON Server using:

node bin --watch db/generate.js

If other.js is changed:

// db/other.jsmodule.exports = function () {
return { bar: [] }
}

generate.js will be reloaded but not other.js because it's cached by
require() and there won't be a http://localhost:3000/bar route.
Scenario 2

Another complicated scenario is if you have the following project
structure:

generate.js
other.js
public/index.html
public/index.js

public/index.js will be watched too. So when public/index.js is changed
it will trigger a reload of generate.js even though it's not required by
generate.js.

—
Reply to this email directly or view it on GitHub
#160 (comment)
.

--Lukas 'SyZer' Gintowt