-
Notifications
You must be signed in to change notification settings - Fork 4
Fix/jupyter sftp port discovery #247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rt since this is expected port that SFTP is externally accessible
jonasbardino
approved these changes
May 30, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed off-list to do the trick since user_sftp_show_port
already negotiates best available SFTP service if not explicitly set.
jonasbardino
referenced
this pull request
May 30, 2025
…the subsyssftp authorized_keys file as a binary instead of the expected string type that is required. Therefore we know force this convertion to ensure that the proper type is written
…so set the sftp_port to user_sftp_show_port after it has been established that either sftp_subsys or sftp is enabled
jonasbardino
pushed a commit
that referenced
this pull request
Jun 4, 2025
git-svn-id: svn+ssh://svn.code.sf.net/p/migrid/code/trunk@6242 b75ad72c-e7d7-11dd-a971-7dbc132099af
jonasbardino
pushed a commit
that referenced
this pull request
Jun 4, 2025
git-svn-id: svn+ssh://svn.code.sf.net/p/migrid/code/trunk@6242 b75ad72c-e7d7-11dd-a971-7dbc132099af
Merged via svn and subsequent merge into migrid-sync |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request aims to fix the issue specified in #246