Skip to content

Fix/jupyter sftp port discovery #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Conversation

rasmunk
Copy link
Contributor

@rasmunk rasmunk commented May 26, 2025

This pull request aims to fix the issue specified in #246

…rt since this is expected port that SFTP is externally accessible
@rasmunk rasmunk changed the base branch from edge to next May 26, 2025 14:09
Copy link
Contributor

@jonasbardino jonasbardino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed off-list to do the trick since user_sftp_show_port already negotiates best available SFTP service if not explicitly set.

@jonasbardino jonasbardino added the bug Something isn't working label May 30, 2025
jonasbardino referenced this pull request May 30, 2025
…the subsyssftp authorized_keys file as a binary instead of the expected string type that is required. Therefore we know force this convertion to ensure that the proper type is written
rasmunk added 3 commits June 4, 2025 09:59
…so set the sftp_port to user_sftp_show_port after it has been established that either sftp_subsys or sftp is enabled
jonasbardino pushed a commit that referenced this pull request Jun 4, 2025
git-svn-id: svn+ssh://svn.code.sf.net/p/migrid/code/trunk@6242 b75ad72c-e7d7-11dd-a971-7dbc132099af
jonasbardino pushed a commit that referenced this pull request Jun 4, 2025
git-svn-id: svn+ssh://svn.code.sf.net/p/migrid/code/trunk@6242 b75ad72c-e7d7-11dd-a971-7dbc132099af
@rasmunk
Copy link
Contributor Author

rasmunk commented Jun 4, 2025

Merged via svn and subsequent merge into migrid-sync

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Any external jupyter service should try to connect to MiGrid via the exposed configuration.user_sftp_show_port
2 participants