PR244 follow-up: allow overriding non-essential GLOBAL and SITE conf options through include sections #249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonasbardino
added this to the Python3 support for general research data sites milestone
…to support peripheral options that we e.g. don't expose in generateconfs or can safely override without daemon interference. Minor reformats to avoid autopep8 from removing line continuation markers.
…rides, which will be useful for docker-migrid deployments without exposing every single config option all the way through `generateconfs.py` and docker-migrid `.env`. Adds restrictions on the *SITE* section as well to prevent changes to service-related `enable_X` options with potential external side effects. Integrates the added unit tests from PR248 but adjusted to fit and test these adjusted override restrictions.
…last pylint sanity check flagged. It most likely is due to the reload flow, but no need to rely on it and we can just fall back to search in the folder where the actual conf file is found. Add `mig_server_home` to the list of override rejects while at it.
…nt generic load conf section messages.
jonasbardino
force-pushed
the
adjust/allow-overriding-certain-peripheral-global-conf-options-through-include-sections
branch
from
4c3705e to
03bacef
Compare
|
Merged through svn |
jonasbardino
deleted the
adjust/allow-overriding-certain-peripheral-global-conf-options-through-include-sections
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #244 follow-up to support certain non-essential GLOBAL option overrides, which will be useful for docker-migrid deployments without exposing every single config option all the way through
generateconfs.pyand docker-migrid.env. Adds restrictions on the SITE section as well to prevent changes to service-relatedenable_Xoptions with potential external side effects.Integrates the added unit tests from PR #248 but adjusted to fit and test these adjusted override restrictions.
Minor style reformatting to avoid autopep8 from removing line continuation markers.