-
Notifications
You must be signed in to change notification settings - Fork 808
Added Aborting Subsequent Workflows section #7077
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Content-wise, it looks great to me 💪
Consider getting a Forms expert (like Ronald), to give a code review.
@ronaldbarendse can you please go through the code in the PR and let me know if something looks off? |
@ronaldbarendse Gentle reminder. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A long overdue comment: I haven't been able to exactly replicate the behavior documented here. All workflows will be executed by default on either submission or approval, regardless of whether one of them failed or sets the record state to rejected. However, once e.g. all submission workflows have executed and one of them sets the record state to rejected, the approval workflows will indeed be skipped (there's no need to return a failed workflow execution status though).
It is possible to add a condition to a workflow to skip execution based on a field value, but that would require 'abusing' a (hidden) field and populating it within another workflow. I wouldn't recommend this though and suggest inheriting the workflow you want to conditionally skip instead to add the conditional logic inside the ExecuteAsync()
method.
Thanks @ronaldbarendse 🙌 Not sure how I missed your review, but I have updated the content to add a Note instead. Can you take a look? |
Description
Based on customer feedback, the article is missing information on how to abort subsequent Workflows through the use of
Rejected
record state. Added a section with some info and an example.Type of suggestion
Product & version (if relevant)
Forms v10, 13, 14, 15, 16
Deadline (if relevant)
Anytime