add acme DNS-01 challenge support via certmagic #202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Semior001
force-pushed
the
feature/110/acme-challenge-certmagic
branch
from
6a070c8 to
5f640e9
Compare
Contributor
Author
|
@umputun any updates? |
Semior001
force-pushed
the
feature/110/acme-challenge-certmagic
branch
from
c84b28b to
631b51e
Compare
Contributor
Author
|
Any chances for it being reviewed? |
Semior001
force-pushed
the
feature/110/acme-challenge-certmagic
branch
from
3d529cc to
048f345
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request adds support for ACME DNS-01 challenges through certmagic, addressing issue #110. Key changes include incorporating new ACME and DNS provider options in the configuration, refactoring the certificate issuance logic to use certmagic, and updating tests and mocks accordingly.
Reviewed Changes
Copilot reviewed 1037 out of 1037 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| app/proxy/dns_provider_mock.go | Introduces a generated mock for DNS provider testing. |
| app/main.go | Adds ACME-related flags and DNS provider options, integrating new providers and configuration. |
| app/proxy/ssl_test.go | Updates tests to validate ACME HTTP and DNS challenge flows with the new certmagic integration. |
| app/proxy/ssl.go | Refactors ACME management to use certmagic, updating interfaces and configuration accordingly. |
| app/proxy/proxy.go | Adds a dnsResolvers field to support testing DNS resolution. |
Co-authored-by: Copilot <[email protected]>
Owner
|
@Semior001 can you take a look why it failed? I have updated group name due to the typo, nothing more |
- Add proper synchronization for DNS mock server - Fix race condition with thread-safe token access - Add timeouts to certificate acquisition to prevent test hanging - Improve error handling in DNS server - Normalize comments with unfuck-ai-comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #110
this implementation is different from #120 in terms that it uses caddy's certmagic package: https://github.com/caddyserver/certmagic