Skip to content

Conversation

@danielroe
Copy link
Member

an upstream change in @types/node means using this as a drop-in fails with type errors

https://app.unpkg.com/@types/[email protected]/files/net.d.ts#L320-337

related PR: DefinitelyTyped/DefinitelyTyped#73870

@codecov
Copy link

codecov bot commented Dec 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 10.27%. Comparing base (5961b7b) to head (41cb785).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #19   +/-   ##
=======================================
  Coverage   10.27%   10.27%           
=======================================
  Files          21       21           
  Lines        3863     3863           
  Branches       79       79           
=======================================
  Hits          397      397           
  Misses       3462     3462           
  Partials        4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

danielroe added a commit to nuxt/test-utils that referenced this pull request Dec 4, 2025
@danielroe danielroe requested a review from pi0 December 4, 2025 14:20
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thnx ❤️

@pi0 pi0 merged commit 17ae300 into main Dec 4, 2025
4 checks passed
@pi0 pi0 deleted the fix/socket-types branch December 4, 2025 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants