Skip to content

feat(prime-vue): add missing components #731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 1, 2024

Conversation

tugcekucukoglu
Copy link
Contributor

@tugcekucukoglu tugcekucukoglu commented Jan 25, 2024

Description

This PR adds missing PrimeVue components

  • FloatLabel
  • IconField
  • InputGroup
  • InputGroupAddon
  • InputIcon
  • InputOtp
  • MeterGroup
  • Stepper
  • StepperPanel

Linked Issues

#730

Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@catgoose
Copy link

DynamicDialog needs to be added as well

@hamedbaatour
Copy link

hamedbaatour commented Feb 25, 2024

Since this PR was first proposed, several new components have been added to PrimeVue. It's crucial to ensure thorough coverage by updating the resolver again to include:

InputOtp
Stepper
FloatLabel
IconField
...

@StyxUA
Copy link

StyxUA commented Apr 21, 2024

Any progress?

@hamedbaatour
Copy link

hamedbaatour commented Apr 23, 2024

@antfu , I'd greatly appreciate it if you could merge this resolver update.

I understand that the frequency of updates across all these components lists can be quite overwhelming, and managing all these PRs might become a bit cumbersome.

So, I suggest considering the addition of a core member from @primevue and other UI libraries as well to a CODEOWNERS file to speed up the validation process for resolver changes.

@antfu antfu changed the title Added PrimeVue missing components feat(prime-vue): add missing components May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants