Skip to content

Update from upstream, remove deprecation notice + version checking #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Changes from 1 commit
Commits
Show all changes
51 commits
Select commit Hold shift + click to select a range
0f5e990
fix(babel-preset-react-app): add missing dependency (#12364)
eventualbuddha May 29, 2023
0a827f6
Migrate from Azure Pipelines to GitHub Actions (#13222)
zpao Jun 14, 2023
736bffe
Update running-tests.md
Olexandr88 Aug 9, 2024
dd420a6
Merge pull request #13644 from Olexandr88/patch-1
eaviles Aug 27, 2024
50d0156
chore: upgrade RTL version to avoid peer-deps mismatch
MatanBobi Dec 26, 2024
02caaa6
Update types from #13725
rickhanlonii Jan 28, 2025
413d2c7
Fix tests
rickhanlonii Jan 28, 2025
9bd1974
Fix e2e tests
rickhanlonii Jan 28, 2025
96f98e9
Add act
rickhanlonii Jan 28, 2025
40936ad
try this instead
rickhanlonii Jan 28, 2025
a8b21a1
update react-scripts react devDep
rickhanlonii Jan 28, 2025
7510aa6
idk
rickhanlonii Jan 28, 2025
0dc2b2d
Update tests
rickhanlonii Jan 28, 2025
32652a5
skip svg component test
rickhanlonii Jan 28, 2025
fde66a2
Merge pull request #13738 from MatanBobi/chores/update-rtl-version-rt…
rickhanlonii Jan 28, 2025
b532a58
Deprecate Create React App officially by changing the README, and add…
orta Jan 28, 2025
3800660
Update deprecation link (#17015)
rickhanlonii Feb 14, 2025
b961be3
Add deprecation to website (#17008)
rickhanlonii Feb 14, 2025
6254386
Publish
rickhanlonii Feb 15, 2025
a239f91
Migrate from Azure Pipelines to GitHub Actions (#13222)
zpao Jun 14, 2023
1a94470
Update running-tests.md
Olexandr88 Aug 9, 2024
bd82320
chore: upgrade RTL version to avoid peer-deps mismatch
MatanBobi Dec 26, 2024
58d2514
Update types from #13725
rickhanlonii Jan 28, 2025
5638a10
Fix tests
rickhanlonii Jan 28, 2025
bcce3a2
Fix e2e tests
rickhanlonii Jan 28, 2025
a8f139a
Add act
rickhanlonii Jan 28, 2025
ea3f425
try this instead
rickhanlonii Jan 28, 2025
23829cb
update react-scripts react devDep
rickhanlonii Jan 28, 2025
479a3bd
idk
rickhanlonii Jan 28, 2025
a76b2e2
Update tests
rickhanlonii Jan 28, 2025
36f0967
skip svg component test
rickhanlonii Jan 28, 2025
6ceff77
Deprecate Create React App officially by changing the README, and add…
orta Jan 28, 2025
d5fa3db
Update deprecation link (#17015)
rickhanlonii Feb 14, 2025
85ca9cb
Add deprecation to website (#17008)
rickhanlonii Feb 14, 2025
54313e1
Publish
rickhanlonii Feb 15, 2025
4b4e7fa
Merge branch 'main' of github.com:facebook/create-react-app into upda…
karlhorky Mar 20, 2025
96f53c9
Disable deprecation warning and version check
karlhorky Mar 20, 2025
a7ca967
Bump version
karlhorky Mar 20, 2025
3b0ab2e
Disable deleting folder after error
karlhorky Mar 20, 2025
e9d2e90
Fix babel-plugin-named-asset-import version number
karlhorky Mar 20, 2025
b9930da
Bump @upleveled/create-react-app to 5.1.2
karlhorky Mar 20, 2025
e62f9ec
Bump version of @upleveled/react-scripts to 5.1.1
karlhorky Mar 20, 2025
772f4e0
Add back call to createApp()
karlhorky Mar 20, 2025
5720b45
Bump version of @upleveled/create-react-app to 5.1.3
karlhorky Mar 20, 2025
b7c1a6b
Revert to published versions of react-scripts dependencies
karlhorky Mar 20, 2025
7c8f70d
Bump version of @upleveled/react-scripts to 5.1.2
karlhorky Mar 20, 2025
f497e62
Allow pnpm to build @parcel/watcher, ignore core-js builds
karlhorky Mar 20, 2025
66c07fb
Bump version of @upleveled/cra-template to 1.3.1
karlhorky Mar 20, 2025
fe46d11
Remove pnpm config from package.json, bump to @upleveled/cra-template…
karlhorky Mar 20, 2025
c2ca687
Add pnpm built packages configuration in `package.json`
karlhorky Mar 20, 2025
03fa529
Bump @upleveled/create-react-app to 5.1.4
karlhorky Mar 20, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add act
  • Loading branch information
rickhanlonii authored and karlhorky committed Mar 20, 2025
commit a8f139aba26538d1e8c61322f788609df0d66ae3
Original file line number Diff line number Diff line change
Expand Up @@ -5,23 +5,28 @@
* LICENSE file in the root directory of this source tree.
*/

import React from 'react';
import * as React from 'react';
import SvgComponent, { SvgComponentWithRef } from './SvgComponent';
import ReactDOMClient from 'react-dom/client';

global.IS_REACT_ACT_ENVIRONMENT = true;

describe('svg component', () => {
it('renders without crashing', () => {
const div = document.createElement('div');
ReactDOMClient.createRoot(div).render(<SvgComponent />);
expect(div.textContent).toBe('logo.svg');
});

it('svg root element equals the passed ref', () => {
it('svg root element equals the passed ref', async () => {
const div = document.createElement('div');
const someRef = React.createRef();
ReactDOMClient.createRoot(div).render(
<SvgComponentWithRef ref={someRef} />
);
// eslint-disable-next-line testing-library/no-unnecessary-act
await React.act(async () => {
ReactDOMClient.createRoot(div).render(
<SvgComponentWithRef ref={someRef} />
);
});
const svgElement = div.getElementsByTagName('svg');
expect(svgElement).toHaveLength(1);
expect(svgElement[0]).toBe(someRef.current);
Expand Down