docs: replace com.vaadin.hilla.Nonnull usages #4155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taefi
reviewed
Feb 27, 2025
There was a problem hiding this comment.
LGTM, but also updated the recommendation of Vaadin about using JSpecify NonNull and Nullable annotations. Asking @cromoteca for a second review.
taefi
reviewed
Feb 28, 2025
taefi
reviewed
Feb 28, 2025
taefi
reviewed
Feb 28, 2025
platosha
reviewed
Mar 4, 2025
cromoteca
requested changes
Mar 17, 2025
cromoteca
requested changes
Mar 19, 2025
Co-authored-by: Luciano Vernaschi <[email protected]>
cromoteca
approved these changes
Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4156
Fixes vaadin/hilla#3350
Replaces usages of the deprecated
com.vaadin.hilla.Nonnullannotation in examples with the jspecify variant.