-
Notifications
You must be signed in to change notification settings - Fork 16
Allow for passing curl options #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@RomainGoncalves Nice, few things: in docs instead of I think it will be more flexible if to overwrite all options with passed to read() options instead of only curl options. It will be more flexible, the difference will be It will require a bit more edits to pass $options array together with $configuration and overwrite options in readConfig() function. I can do this edits a bit later. |
@vedmant Thanks for the nice words. |
@RomainGoncalves Ok, I'll merge current PR, but I'll change it a bit later, to avoid breaking change could you just update to make it pass curl options as 'curl_options' key in array: |
@RomainGoncalves Please fix |
@vedmant sorry about that. Somehow the tests did not catch on it. Fixed now |
@vedmant quick question, is that change sent to packagist straight away? Can I update my dependencies and have the changes now? |
Yes, it should update now
…On Fri, May 28, 2021, 9:28 PM Romain Goncalves ***@***.***> wrote:
@vedmant <https://github.com/vedmant> quick question, is that change sent
to packagist straight away? Can I update my dependencies and have the
changes now?
Thanks
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#14 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABGRP5VDQTXA46R6W73WUQTTP7OERANCNFSM45UP4KMQ>
.
|
Thanks I saw that. |
This PR aims to allow the user to pass along to the
read
method some curl options.Scenario
If you want to read a feed from a platform/website that requires authentication, you can't at the moment.
By passing curl options manually to the
read
method, the user can add any tools that they would require per call.