Skip to content

2 deallocation done in different function can cause underflow #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
veeso merged 3 commits into from
Dec 21, 2025
Merged

2 deallocation done in different function can cause underflow #3

veeso merged 3 commits into from
Dec 21, 2025

Conversation

@veeso
Copy link
Owner

@veeso veeso commented Dec 21, 2025

  • fix: Fixed deallocation trace by looking up the symbol ONLY at allocation and by storing a pointer -> Symbol table
  • fix: track ptr to symbol
  • fix: MacOS compatibility

Fixes #2

veeso added 3 commits December 21, 2025 11:23
@veeso
fix: Fixed deallocation trace by looking up the symbol ONLY at alloca…
ea3da61 
…tion and by storing a pointer -> Symbol table

The underflow issue was already solved, this pr added a map to map the ptr to the symbol name to correctly trace the deallocation

closes #2
@veeso
fix: track ptr to symbol
869563b
@veeso
fix: MacOS compatibility
89f2a44
@cocogitto-bot
Copy link

cocogitto-bot bot commented Dec 21, 2025

✔️ ea3da61...89f2a44 - Conventional commits check succeeded.

@coveralls
Copy link

coveralls commented Dec 21, 2025

Pull Request Test Coverage Report for Build 20408682619

Details

  • 35 of 48 (72.92%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-3.0%) to 82.09%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/symbols.rs 11 12 91.67%
src/alloc.rs 24 36 66.67%
Files with Coverage Reduction New Missed Lines %
src/alloc.rs 2 66.13%
Totals Coverage Status
Change from base Build 20136967220: -3.0%
Covered Lines: 220
Relevant Lines: 268
💛 - Coveralls

@veeso veeso merged commit 047dd38 into main Dec 21, 2025
7 checks passed
@veeso veeso deleted the 2-deallocation-done-in-different-function-can-cause-underflow branch December 21, 2025 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

deallocation done in different function can cause underflow

3 participants

@veeso @coveralls