You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have searched the issues of this repo and believe that this is not a duplicate
OS version and name: macOS Sierra 10.12
Hyper.app version: 0.8.3
Relevent information from devtools:
bundle.js:17759 Uncaught TypeError: Cannot read property 'children' of undefined
The issue is reproducible in vanilla Hyper.app:
Issue
Closing Tab call the CLOSE_TAB event. The event work with a single session opened. With 2 sessions or more There is an error from the dispatch of userExitTermGroup(uid)
Testing this with Tab then 2 session
Term-group UID: "969e616e-fdf9-4ed8-8f7c-d3d599f7cd5a"
Term-group children: [ "ac4105f5-2780-49fa-8b44-68e1aadeefd1", "f92333bf-6bad-4ad7-98fa-32722192f6b9"]
Now in the userExitTermGroup(uid) we can see 2 cases at the end:
We can see in the else case that on the new dispatch(userExitTermGroup(childUid));. The group dosen't have children anymore since they where called in the first else pass.
Testing this in my PR I can see that. With a single pane.
I can console.log(onRoot EXIT called)
But with more than one Pane. No action are received.
UPDATE
After more investigation, it look like the closeTab(i) go for closing the active session but not the - activeTab.
The current process close only one session and keep others open in the pty.
The text was updated successfully, but these errors were encountered:
Issue
Closing Tab call the
CLOSE_TAB
event. The event work with a single session opened. With 2 sessions or more There is an error from the dispatch ofuserExitTermGroup(uid)
Testing this with Tab then 2 session
Term-group UID:
"969e616e-fdf9-4ed8-8f7c-d3d599f7cd5a"
Term-group children:
[ "ac4105f5-2780-49fa-8b44-68e1aadeefd1", "f92333bf-6bad-4ad7-98fa-32722192f6b9"]
Now in the
userExitTermGroup(uid)
we can see 2 cases at the end:We can see in the else case that on the new
dispatch(userExitTermGroup(childUid));
. Thegroup
dosen't have children anymore since they where called in the firstelse
pass.Testing this in my PR I can see that. With a single pane.
I can
console.log(onRoot EXIT called)
But with more than one Pane. No action are received.
UPDATE
closeTab(i)
go for closing the active session but not the - activeTab.The text was updated successfully, but these errors were encountered: