Hyper Sessions restoration

[ppot]

Working on this again

Iteration circle into multiple PR.
Closes Issues #785, #567

Provide

app quit and process quit -> state restoration after shutdown / restart

This PR includes important changes in order to allow sessions record and restoration.

Concern

At the moment, the session is not affiliated to any opened tabs or splits in the win object. Sessions are created and then added to the sessions map in the win object so each win inside the windowsSet has multiples session.

Update

• Add win folder
• Add window object extanding BrowserWindow
• window now have a Set of Tab
• Tab now include a root Pane and each pane have childs

Apply hyper

Record

• periodically save state
• record all windows positions and sizes
• record windows opened tabs
• record tab root Pane and childs
• record each Pane session cwd

Restoration

• restore windows
• restore windows tabs
• restore tab Pane and child
• restore Pane session cwd

This way, we can record the windowSet object and apply the restoration on restart and reload the precedent recorded state.

[ivands]

+1 please add this fast ;D

[ppot]

@ivands Still have a few glitch! But working on it!

[ppot]

Commit e1ee608 close #1046

[ppot]

@matheuss @rauchg Review Needed

[ppot]

@VinceBT I started a thread for this feature, but nobody answered yet!

[ppot]

@rauchg Any take on how you would see session restoration?

[ppot]

@chabou, @rauchg While trying to make a session restoration plugin. I came across this problem. Since I can't share a state between

exports.onApp = () => {
}

exports.onWindow = (window) => {
}

and

exports.middleware = (store) => (next) => (action) => {
}

I can't have a global state residing inside my plugin. The reason is since we decouple the backend and the front-end.

While I can listed to onWindow event for new window, I can store them great. Same for the middleware I can invoke specific action and create new recorded session with their desired state. But still. If I make a recorder on top of it. each window will have a undefined instance of the window it's create and if I make the recorder inside let say:

  if ('INIT' === action.type) {
      const window = new Window('INIT');
      record.onWindow(window);
      console.log(reccord);
  }

Each window will have one instance of the recorder. So how would we share this state between the two.

The ideal way would be to listed to the RPC localy inside the plugin on the hyper process level. The other way around would be to totally integrate the session recorder inside hyper-core like at the present level of this PR.

In order to have this possibility we could separate the RPC in two.

• One rendererRPC = which is the rendered Window.
  • decorating the Term
• One terminalRPC = which is the terminal process.
  • new window
  • new session
  • And so on..

One hacky way, which is code-smelling would be to have a stored state in a local file and make read/write action for every updated state which is not the goal here. No need to make multiple IO and slowing the term.

I am open for comment and suggestions.

[chucklu]

Have the same feature request

[autonome]

One hacky way, which is code-smelling would be to have a stored state in a local file and make read/write action for every updated state which is not the goal here. No need to make multiple IO and slowing the term.

Reading this issue gave me flashbacks: I implemented session save/restore in Firefox 2 in 2006. It basically worked the way you describe here.

12 years later, Mozilla is almost finished making that code not slow (😂+😭), but protecting user data is a trade-off I'd make 100x over again.

Off-by-default-until-fast is a nice balance between performance and protection, if that's easier to swallow than some interim perf hit. But no protection option leaves us developers living in fear 😅

[wclr]

If not to restore sessions, is it currently possible to create some predefined (config layout) on the app start, so it would open needed tabs and split pane and need?

[caina-jumia]

If not to restore sessions, is it currently possible to create some predefined (config layout) on the app start, so it would open needed tabs and split pane and need?

I use hypercwd and set initialWorkingDirectory to my desire

[wclr]

@caina-jumia I too use it, but I need tabs and split panes setup.

[Stanzilla]

@ppot worth keeping this open or will you make a new one when you work on this again anyway?

[ppot]

@Stanzilla worth keep it open. I'm exploring the rust binding for speed

[Stanzilla]

Oops miss clicked, alright then!

[JWess]

Is this dead?

[zradeg]

Hey, @ppot! Have you any progress in this task?
It's really rescue thing, anyway.

Appositely, thank you a lot for you work!

[MentalGear]

This seems almost done, right ?

[LabhanshAgrawal]

This seems almost done, right ?

No
It'll need to be updated as the codebase has been ported to typescript, and has changed quite a bit.

[Amesys]

Hi reviewers, any status on this feature ?
Would be quite handy to have.

[skm7463]

Hi Guys, I just want to understand the request as I'm working on something myself.

Is the request to save & restore tabs, panes, windows, positions and cwd for each?

Have I missed anything?

[LabhanshAgrawal]

Hi reviewers, any status on this feature ?
Would be quite handy to have.

no updates right now, though it might be doable now as we've started releasing again and so the development should pick up a bit.

Hi Guys, I just want to understand the request as I'm working on something myself.

Is the request to save & restore tabs, panes, windows, positions and cwd for each?

Have I missed anything?

that's all I guess, you can also include restoring terminal content using xterm serialization addon if you want.

[skm7463]

Hi reviewers, any status on this feature ?
Would be quite handy to have.

no updates right now, though it might be doable now as we've started releasing again and so the development should pick up a bit.

Hi Guys, I just want to understand the request as I'm working on something myself.
Is the request to save & restore tabs, panes, windows, positions and cwd for each?
Have I missed anything?

that's all I guess, you can also include restoring terminal content using xterm serialization addon if you want.

... From what I can see so far the serialization addon saves out the terminal buffer, not yet sure how that would be useful for restoring it because ultimately I assume the goal would be to restore the shell session which is a different issue especially the command state and process state in the shell.

I've already handled capture and save options of terminal content anyway and gone a little further than the serialisation addon.

Any ideas on approaching restoring the shell process state are very welcome

[lfaveur]

Hi this feature is it still relevant? or is it abandoned?

[iljaiwjew]

Is it done or WIP or else?

[tendallas]

What is the current status? It's almost 4 years ( What does blocks this feature?

[ghost]

Circling back to this, has this been reviewed or help is needed? The session restoration feature is something that is quite handy

[jacobhillock]

I am looking to migrate over to here, this feature is a must have. Thank you!

[sagarpanchal]

I am looking to migrate over to here, this feature is a must have. Thank you!

I have been waiting since 2020

[michaelsieminski]

this would be cool, but i guess it's not happening since its here since 2016 xD

[brun0xff]

I have been waiting for this since 2017