Fix missing user objects in --lib-create mode. #3784
Conversation
|
Fix #3780 |
There was a problem hiding this comment.
Thanks the fix seems reasonable.
Could you see if we can improve e.g. t_lib_prot.pl and t_lib_nolib.pl to check for this case, for example create a little t_lib_prot_c.cpp file that has a function in it, and add t_lib_prot_c.cpp to the verilator_flags2 command line when the library is made. That should fail without your patch then pass with it.
poemonsense
force-pushed
the
patch-lib-create-objects
branch
5 times, most recently
from
479c44b to
c8814be
Compare
|
I've updated the t_lib_prot.pl test case, which fails before the last commit and succeeds after the fix. Don't know really I did it in the correct way, but I found it not work as expected for the verilator_flags2. It seems verilator_flags2 will compile the simulation binary (elf) instead of a lib, where verilator always generates the objects rules. |
|
Oh, test_regress has a special Makefile so that's conflicting, sorry about that suggestion. I guess I can take this without a test, so back out the test_regress changes and I'll merge, thanks. |
When Verilator is called with `--lib-create` and user-specified cpp files, it should generate make rules for these user objects. Signed-off-by: Yinan Xu <[email protected]>
poemonsense
force-pushed
the
patch-lib-create-objects
branch
from
dd7a871 to
bdbccfa
Compare
|
Updated. |
When Verilator is called with
--lib-createand user-specified cpp files, it should generate make rules for these user objects.Signed-off-by: Yinan Xu [email protected]