Skip to content

Film sample relationships fix typos & use carrier specific relationships #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 2, 2025

Conversation

lucasotodegraeve
Copy link
Contributor

  • "is represented by" must not not contain any newlines
  • add missing "copy" to relationships
  • use carrier specific relationship

- "is represented by" must not not conain any newlines
- add missing "copy" to is_x_copy relationships
@lucasotodegraeve lucasotodegraeve requested a review from mielvds May 19, 2025 13:16
Copy link
Collaborator

@mielvds mielvds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we avoid spaces here?

@lucasotodegraeve
Copy link
Contributor Author

Fine by me. But we should have a consistent vocabulary.

IRI With spaces Without spaces
rel:isr is represented by isRepresentedBy
rel:rep represents represents
rel:inc includes includes
rel:isi is included in isIncludedIn
haObj:hasMasterCopy has master copy hasMasterCopy
haObj:isMasterCopyOf is master copy of isMasterCopyOf

Some of these look kind of funky, but it's alright for me to skip the spaces. What do you think?

The standard vocabulary can be found at https://id.loc.gov/vocabulary/preservation/relationshipSubType.html

@mielvds
Copy link
Collaborator

mielvds commented May 20, 2025

The standard vocabulary can be found at https://id.loc.gov/vocabulary/preservation/relationshipSubType.html

Yeah, that's the only reason why I would include spaces, but it's a good one. Let's keep the spaces; it's what's in the reference examples as well: https://www.loc.gov/standards/premis/v3/sample-records/PREMIS%203%20example%201.xml

@lucasotodegraeve
Copy link
Contributor Author

I kept the spaces and added the haObj relationship sub types to the documentation.

@lucasotodegraeve lucasotodegraeve merged commit c68abc3 into main Jun 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants