-
Notifications
You must be signed in to change notification settings - Fork 292
allow Gemfile gems to be parsed and required #167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
there you go, @segfault . |
|
is this still visible? merge, anyone? |
|
I get segfaults when I enable this. |
allow Gemfile gems to be parsed and required
|
no segfaults here, offhand I'm guessing that it'll depend on what Gems end up being loaded into the ruby interpreter within vim. |
|
I'm getting the segfault at the "Bundler.require" line. Tips on how to track that down further in Vim would be appreciated. Here's my Gemfile (you probably need to 'bundle install' after creating this): source 'https://rubygems.org' And here is a test program to demo the segfault: #!/usr/bin/env ruby require 'savon' |
|
And here's another with a completely different gem. .vimrc: Gemfile: test_crash.rb: |
|
I just recreated your crash, but I get it without the changes from this pull req. |
|
Are you sure? The crash goes away for me when I comment out the Bundler.require line. |
|
Yup. I just reset on the previous commit and checked the file to be a bit more certain. Are you also seeing it on a OSX box? |
|
Yes, this is OS X. But I'm afraid that I cannot replicate the crash before including the merge. I just tested the following:
|
|
Offhand I'm guessing that I have more of the settings enabled that cause buffer loading. I'll have a go at bisecting and debugging this further tomorrow. Crashes like these are nasty since they are sometimes due to limitations on the embedded ruby vm. |
|
everything that's happening asynchronous can lead to vim crashes, maybe it's in the Bundler.require call. Do you use an async autocompletion plugin like YCM? |
|
@tek Just supertab. I've tested and repeated the crash after removing everything except pathogen, vim-ruby, and stripping down my .vimrc to this: call pathogen#infect() filetype plugin indent on let g:rubycomplete_load_gemfile = 1 Bundler.require works fine when invoked from my scripts (outside of vim). Maybe Mark is correct about an embedded ruby issue? |
|
Probably. Which vim version are you running? |
|
joel@pds-macbook-air:~$ vim --version |
hey there, I didn't see a way to complete gems that are pulled in via Bundler.require, so I made this.