Skip to content

[Doc] Fix typo in the help message of '--guided-decoding-backend' #11440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 23, 2024
Merged

[Doc] Fix typo in the help message of '--guided-decoding-backend' #11440

merged 1 commit into from
Dec 23, 2024

Conversation

yansh97
Copy link
Contributor

@yansh97 yansh97 commented Dec 23, 2024 •
edited by github-actions bot
Loading

Added a space, otherwise the effect is as shown in the picture below.

image

@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@yansh97 yansh97 changed the title [Bugfix] Fix typo in the help message of '--guided-decoding-backend' [Doc] Fix typo in the help message of '--guided-decoding-backend' Dec 23, 2024
@mgoin mgoin added the ready ONLY add when PR is ready to merge/full CI is needed label Dec 23, 2024
@mgoin mgoin enabled auto-merge (squash) December 23, 2024 16:54
DarkLight1337
DarkLight1337 approved these changes Dec 23, 2024
View reviewed changes
Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@mgoin mgoin merged commit 94d545a into vllm-project:main Dec 23, 2024
70 checks passed
@yansh97 yansh97 deleted the patch-1 branch December 24, 2024 01:29
mzusman pushed a commit to mzusman/vllm that referenced this pull request Mar 12, 2025
@yansh97 @mzusman
[Doc] Fix typo in the help message of '--guided-decoding-backend' (vl…
af23d3e 
…lm-project#11440)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mgoin mgoin mgoin approved these changes

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

Assignees

No one assigned

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yansh97 @mgoin @DarkLight1337