Skip to content

[Bugfix] Fix use_cascade_attention handling for Alibi-based models on vllm/v1 #15211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Mar 27, 2025
Merged

[Bugfix] Fix use_cascade_attention handling for Alibi-based models on vllm/v1 #15211

merged 10 commits into from
Mar 27, 2025

Conversation

h-sugi
Copy link
Contributor

@h-sugi h-sugi commented Mar 20, 2025 •
edited by github-actions bot
Loading

When using Alibi-based models like MPT, the following assertion error causes.

AssertionError: Cascade attention does not support ALiBi.

This is because that the determination logic for use_cascade in gpu_model_runner.py incorrectly uses a hard-coded use_alibi=False. Therefore, cascade_attention is wrongly enabled.

This PR allows setting use_alibi based on the alibi configuration specified in the config.json for MPT models.

@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the v1 label Mar 20, 2025
WoosukKwon
WoosukKwon reviewed Mar 20, 2025
View reviewed changes
Copy link
Collaborator

@WoosukKwon WoosukKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@h-sugi Thanks for the PR! Left some minor comments.

h-sugi and others added 4 commits March 21, 2025 09:00
WoosukKwon
WoosukKwon approved these changes Mar 21, 2025
View reviewed changes
@h-sugi
fommater
893ef8a 
Signed-off-by: h-sugi <[email protected]>
@mergify Mergify
Copy link

mergify bot commented Mar 22, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @h-sugi.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Mar 22, 2025
@mergify mergify bot removed the needs-rebase label Mar 22, 2025
@WoosukKwon WoosukKwon added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 27, 2025
@WoosukKwon
Copy link
Collaborator

@h-sugi Thanks for updating the PR! I will merge if the tests go well.

@DarkLight1337 DarkLight1337 merged commit 8958217 into vllm-project:main Mar 27, 2025
39 checks passed
Alex4210987 pushed a commit to LeiWang1999/vllm-bitblas that referenced this pull request Apr 5, 2025
@h-sugi @WoosukKwon @Alex4210987
[Bugfix] Fix use_cascade_attention handling for Alibi-based models on…
8a6caa4 
… vllm/v1 (vllm-project#15211)

Signed-off-by: h-sugi <[email protected]>
Co-authored-by: Woosuk Kwon <[email protected]>
Signed-off-by: xinyuxiao <[email protected]>
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
@h-sugi @WoosukKwon @lulmer
[Bugfix] Fix use_cascade_attention handling for Alibi-based models on…
5fb8471 
… vllm/v1 (vllm-project#15211)

Signed-off-by: h-sugi <[email protected]>
Co-authored-by: Woosuk Kwon <[email protected]>
Signed-off-by: Louis Ulmer <[email protected]>
@ckhordiasma ckhordiasma mentioned this pull request Apr 17, 2025
Closed
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
@h-sugi @WoosukKwon @lk-chen
[Bugfix] Fix use_cascade_attention handling for Alibi-based models on…
a93eb2c 
… vllm/v1 (vllm-project#15211)

Signed-off-by: h-sugi <[email protected]>
Co-authored-by: Woosuk Kwon <[email protected]>
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
@h-sugi @WoosukKwon @shreyankg
[Bugfix] Fix use_cascade_attention handling for Alibi-based models on…
36d1471 
… vllm/v1 (vllm-project#15211)

Signed-off-by: h-sugi <[email protected]>
Co-authored-by: Woosuk Kwon <[email protected]>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@h-sugi @WoosukKwon
[Bugfix] Fix use_cascade_attention handling for Alibi-based models on…
5731d9c 
… vllm/v1 (vllm-project#15211)

Signed-off-by: h-sugi <[email protected]>
Co-authored-by: Woosuk Kwon <[email protected]>
Signed-off-by: Mu Huai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@WoosukKwon WoosukKwon WoosukKwon approved these changes

@robertgshaw2-redhat robertgshaw2-redhat Awaiting requested review from robertgshaw2-redhat

@njhill njhill Awaiting requested review from njhill

@ywang96 ywang96 Awaiting requested review from ywang96

@comaniac comaniac Awaiting requested review from comaniac

@alexm-redhat alexm-redhat Awaiting requested review from alexm-redhat

Assignees

No one assigned

Labels

ready ONLY add when PR is ready to merge/full CI is needed v1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@h-sugi @WoosukKwon @DarkLight1337