Skip to content

Fix raw_request extraction in load_aware_call decorator #15382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 26, 2025
Merged

Fix raw_request extraction in load_aware_call decorator #15382

merged 1 commit into from
Mar 26, 2025

Conversation

daniel-salib
Copy link
Contributor

@daniel-salib daniel-salib commented Mar 24, 2025 •
edited by github-actions bot
Loading

Remove raw_request as keyword arg for load_aware_call_decorator and extract from the args

FIX #15371

@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the frontend label Mar 24, 2025
@daniel-salib daniel-salib force-pushed the daniel/server-load-args branch 2 times, most recently from 54d239b to d154a56 Compare March 24, 2025 12:20
@daniel-salib daniel-salib marked this pull request as ready for review March 24, 2025 12:35
youngkent
youngkent reviewed Mar 24, 2025
View reviewed changes
@daniel-salib daniel-salib marked this pull request as draft March 24, 2025 17:59
@daniel-salib daniel-salib force-pushed the daniel/server-load-args branch from d154a56 to 5828d5e Compare March 24, 2025 18:09
@daniel-salib daniel-salib marked this pull request as ready for review March 24, 2025 18:09
@daniel-salib daniel-salib force-pushed the daniel/server-load-args branch 2 times, most recently from 14735ad to 82e7edd Compare March 25, 2025 00:28
youngkent
youngkent reviewed Mar 25, 2025
View reviewed changes
@daniel-salib daniel-salib force-pushed the daniel/server-load-args branch 3 times, most recently from 298cede to 9924320 Compare March 25, 2025 11:28
@daniel-salib daniel-salib requested a review from youngkent March 25, 2025 16:40
youngkent
youngkent reviewed Mar 25, 2025
View reviewed changes
@daniel-salib daniel-salib force-pushed the daniel/server-load-args branch from 9924320 to 6e49631 Compare March 25, 2025 20:13
youngkent
youngkent approved these changes Mar 26, 2025
View reviewed changes
Copy link
Contributor

@youngkent youngkent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

DarkLight1337
DarkLight1337 approved these changes Mar 26, 2025
View reviewed changes
Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) March 26, 2025 02:55
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 26, 2025
@simon-mo simon-mo disabled auto-merge March 26, 2025 05:29
@simon-mo simon-mo merged commit 5aefd6a into vllm-project:main Mar 26, 2025
39 of 41 checks passed
@e-dixo e-dixo mentioned this pull request Apr 6, 2025
Closed
1 task
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
@daniel-salib @lulmer
Fix raw_request extraction in load_aware_call decorator (vllm-project…
e1083c0 
…#15382)

Signed-off-by: Daniel Salib <[email protected]>
Signed-off-by: Louis Ulmer <[email protected]>
@ckhordiasma ckhordiasma mentioned this pull request Apr 17, 2025
Closed
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
@daniel-salib @lk-chen
Fix raw_request extraction in load_aware_call decorator (vllm-project…
e0a1d15 
…#15382)

Signed-off-by: Daniel Salib <[email protected]>
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
@daniel-salib @shreyankg
Fix raw_request extraction in load_aware_call decorator (vllm-project…
84e066a 
…#15382)

Signed-off-by: Daniel Salib <[email protected]>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@daniel-salib
Fix raw_request extraction in load_aware_call decorator (vllm-project…
a2d2acc 
…#15382)

Signed-off-by: Daniel Salib <[email protected]>
Signed-off-by: Mu Huai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

+1 more reviewer

@youngkent youngkent youngkent approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

frontend ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: Error occurred in v1/rerank interface after upgrading from version 0.7.3 to 0.8.1

4 participants

@daniel-salib @youngkent @DarkLight1337 @simon-mo