-
-
Notifications
You must be signed in to change notification settings - Fork 10.6k
[moe][quant] add weight name case for offset #15515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you going to contribute an integration for the modelslim format? This seems fine to land, but it is a bit strange to have this fix without actually having the format integrated upstream
Acctually this is a fix for downstream vllm-ascend, we are integrating modelslim into vllm-ascend through vllm-project/vllm-ascend#391. And modelslim is a quant tool for Ascend NPU, I think we'd better make smallest change in vLLM upstream, thus only adding |
Signed-off-by: Mengqing Cao <[email protected]>
I see, thanks for the context. LGTM then! |
Thanks! 👍 |
Signed-off-by: Mengqing Cao <[email protected]> Signed-off-by: xinyuxiao <[email protected]>
Signed-off-by: Mengqing Cao <[email protected]> Signed-off-by: Louis Ulmer <[email protected]>
Signed-off-by: Mengqing Cao <[email protected]>
Signed-off-by: Mengqing Cao <[email protected]>
Signed-off-by: Mengqing Cao <[email protected]> Signed-off-by: Mu Huai <[email protected]>
This PR adds weight name case for
offset
, thus making it compatible with some quantization tools that name zero-points asoffsets
, e.g., modelslim