Skip to content

Revert "doc: add info for macos clang errors (#16049)" #16091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 5, 2025
Merged

Revert "doc: add info for macos clang errors (#16049)" #16091

merged 1 commit into from
Apr 5, 2025

Conversation

yihong0618
Copy link
Contributor

This patch follow up #16086 revert the doc

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 5, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@yihong0618 yihong0618 force-pushed the hy/revert_no_need_doc branch from 0751341 to 4ee5355 Compare April 5, 2025 10:19
@mergify mergify bot added the documentation Improvements or additions to documentation label Apr 5, 2025
hmellor
hmellor approved these changes Apr 5, 2025
View reviewed changes
Copy link
Member

@hmellor hmellor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hmellor hmellor enabled auto-merge (squash) April 5, 2025 11:05
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Apr 5, 2025
@hmellor hmellor merged commit 6baeee7 into vllm-project:main Apr 5, 2025
37 of 39 checks passed
Alex4210987 pushed a commit to LeiWang1999/vllm-bitblas that referenced this pull request Apr 5, 2025
@yihong0618 @Alex4210987
Revert "doc: add info for macos clang errors (vllm-project#16049)" (v…
faaf503 
…llm-project#16091)

Signed-off-by: yihong0618 <[email protected]>
Signed-off-by: xinyuxiao <[email protected]>
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
@yihong0618 @lulmer
Revert "doc: add info for macos clang errors (vllm-project#16049)" (v…
32d8fab 
…llm-project#16091)

Signed-off-by: yihong0618 <[email protected]>
Signed-off-by: Louis Ulmer <[email protected]>
yangw-dev pushed a commit to yangw-dev/vllm that referenced this pull request Apr 21, 2025
@yihong0618 @yangw-dev
Revert "doc: add info for macos clang errors (vllm-project#16049)" (v…
567e79a 
…llm-project#16091)

Signed-off-by: yihong0618 <[email protected]>
Signed-off-by: Yang Wang <[email protected]>
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
@yihong0618 @lk-chen
Revert "doc: add info for macos clang errors (vllm-project#16049)" (v…
a657f18 
…llm-project#16091)

Signed-off-by: yihong0618 <[email protected]>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@yihong0618
Revert "doc: add info for macos clang errors (vllm-project#16049)" (v…
9f89402 
…llm-project#16091)

Signed-off-by: yihong0618 <[email protected]>
Signed-off-by: Mu Huai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hmellor hmellor hmellor approved these changes

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yihong0618 @hmellor