Skip to content

Conversation

ywang96
Copy link
Member

@ywang96 ywang96 commented Apr 6, 2025

llguidance.LLMatcher.validate_grammar no longer takes tokenizer as a keyword argument (not sure if this is a bug on their side), but this has caused V1 test to always break on main.

This PR fixes it.

tests/v1/entrypoints/llm/test_struct_output_generate.py ....                                                                                                           [100%]

============================================================================== warnings summary ==============================================================================
tests/v1/entrypoints/llm/test_struct_output_generate.py::test_structured_output[mistralai/Ministral-8B-Instruct-2410-xgrammar:disable-any-whitespace-auto]
tests/v1/entrypoints/llm/test_struct_output_generate.py::test_structured_output[mistralai/Ministral-8B-Instruct-2410-guidance:disable-any-whitespace-auto]
  /home/jovyan/vllm/vllm/transformers_utils/tokenizer_group/tokenizer_group.py:25: FutureWarning: It is strongly recommended to run mistral models with `--tokenizer-mode "mistral"` to ensure correct encoding and decoding.
    self.tokenizer = get_tokenizer(self.tokenizer_id, **tokenizer_config)

tests/v1/entrypoints/llm/test_struct_output_generate.py::test_structured_output[mistralai/Ministral-8B-Instruct-2410-xgrammar:disable-any-whitespace-auto]
tests/v1/entrypoints/llm/test_struct_output_generate.py::test_structured_output[mistralai/Ministral-8B-Instruct-2410-guidance:disable-any-whitespace-auto]
tests/v1/entrypoints/llm/test_struct_output_generate.py::test_structured_output[mistralai/Ministral-8B-Instruct-2410-xgrammar:disable-any-whitespace-mistral]
tests/v1/entrypoints/llm/test_struct_output_generate.py::test_structured_output[Qwen/Qwen2.5-1.5B-Instruct-xgrammar:disable-any-whitespace-auto]
  /home/jovyan/.local/share/uv/python/cpython-3.12.9-linux-x86_64-gnu/lib/python3.12/multiprocessing/popen_fork.py:66: DeprecationWarning: This process (pid=132348) is multi-threaded, use of fork() may lead to deadlocks in the child.
    self.pid = os.fork()

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
================================================================== 4 passed, 6 warnings in 75.87s (0:01:15) ==================================================================

Signed-off-by: Roger Wang <[email protected]>
@ywang96 ywang96 requested review from mgoin and russellb as code owners April 6, 2025 05:46
Copy link

github-actions bot commented Apr 6, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the v1 label Apr 6, 2025
@ywang96 ywang96 added the ready ONLY add when PR is ready to merge/full CI is needed label Apr 6, 2025
Copy link
Member

@mgoin mgoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DarkLight1337 DarkLight1337 merged commit 9ca710e into main Apr 6, 2025
60 checks passed
@DarkLight1337 DarkLight1337 deleted the fix-guided branch April 6, 2025 08:18
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
lengrongfu pushed a commit to lengrongfu/vllm that referenced this pull request Apr 7, 2025
yangw-dev pushed a commit to yangw-dev/vllm that referenced this pull request Apr 21, 2025
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed v1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants