Skip to content

Conversation

DefTruth
Copy link
Contributor

@DefTruth DefTruth commented Apr 6, 2025

Remove redundant Exp calculations

Copy link

github-actions bot commented Apr 6, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mgoin mgoin requested a review from LucasWilkinson April 7, 2025 19:47
@DefTruth
Copy link
Contributor Author

@LucasWilkinson PTAL, thanks~

Copy link
Collaborator

@LucasWilkinson LucasWilkinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution!

@LucasWilkinson LucasWilkinson enabled auto-merge (squash) April 13, 2025 04:22
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Apr 13, 2025
@DefTruth
Copy link
Contributor Author

@LucasWilkinson some tests failed, but it seems not related to this PR.

@DefTruth
Copy link
Contributor Author

weird, i don't why the mamba kernel tests failed

FAILED kernels/test_mamba_ssm_ssd.py::test_mamba_chunk_scan_cont_batch[seq_len_chunk_size_cases0-5-8-itype0]
 AssertionError: chunk_indices and chunk_offsets should have been set

@DefTruth
Copy link
Contributor Author

The mamba ssd kernel test failed, related PR #16623

@LucasWilkinson LucasWilkinson merged commit 280d62b into vllm-project:main Apr 15, 2025
45 checks passed
@DefTruth DefTruth deleted the remove-redundant-exp branch April 15, 2025 15:46
yangw-dev pushed a commit to yangw-dev/vllm that referenced this pull request Apr 21, 2025
jikunshang pushed a commit to jikunshang/vllm that referenced this pull request Apr 29, 2025
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants